1510664 - Performance Warning: HashMap can be replaced with SparseArray

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

For maps where the keys are of type integer, it's typically more efficient to use the Android SparseArray API. This check identifies scenarios where you might want to consider using SparseArray instead of HashMap for better performance.  

This is particularly useful when the value types are primitives like ints, where you can use SparseIntArray and avoid auto-boxing the values from int to Integer.  

If you need to construct a HashMap because you need to call an API outside of your control which requires a Map, you can suppress this warning using for example the @SuppressLint annotation.

Affected Classes:

GeckoSurfaceTexure

Comment 1

[cschanaj]

Attachment: Bug 1510664 - Replace `HashMap` with `SparseArray`

This PR replaces HashMap with SparseArray from the Android API to
improve memory efficiency and performance.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d86e37de9470
Replace `HashMap` with `SparseArray` r=agi

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d86e37de9470