1510666 - Performance Warning: Obsolete SDK_INT Version Check

Status: NEW

(GeckoView :: General, defect, P5)

Description

[Emily Toop (:fluffyemily)]

This check flags version checks that are not necessary, because the minSdkVersion (or surrounding known API level) is already at least as high as the version checked for.  

Similarly, it also looks for resources in -vNN folders, such as values-v14 where the version qualifier is less than or equal to the minSdkVersion, where the contents should be merged into the best folder.

Affected Classes:

AndroidGamepadManager
VideoCaptureDeviceInfoAndroid

Comment 1

[Logan Rosen [:Logan]]

Attachment: Bug 1510666 - remove obsolete SDK_INT version checks r?#geckoview-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 3

[Makoto Kato [:m_kato]]

Obsolete SDK_INT Version Check
../../../../../../../mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoBundle.java:963: Unnecessary; SDK_INT is always >= 21

But this code runs on Java unit test, so we cannot remove it. So we should use @SuppressLint("ObsoleteSdkInt").

Comment 4

[Polly [:polly]]

(In reply to Emily Toop (:fluffyemily) from comment #0)

This check flags version checks that are not necessary, because the
minSdkVersion (or surrounding known API level) is already at least as high
as the version checked for.

Similarly, it also looks for resources in -vNN folders, such as values-v14
where the version qualifier is less than or equal to the minSdkVersion,
where the contents should be merged into the best folder.

Affected Classes:

AndroidGamepadManager
VideoCaptureDeviceInfoAndroid

Please note that the classes marked as affected here are no longer an issue. (AndroidGamepadManager, VideoCaptureDeviceInfoAndroid)
See comment 3 above for the class that is still affected here. GeckoBundle