1510667 - Performance Warning: Should use valueOf instead of new

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

You should not call the constructor for wrapper classes directly, such as`new Integer(42)`. Instead, call the valueOf factory method, such as Integer.valueOf(42). This will typically use less memory because common integers such as 0 and 1 will share a single instance.

Affected Classes:

GeckoAppShell

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1510667 - Performance Warning: Should use valueOf instead of new. r=#geckoview-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19d8c3a76b9c
Performance Warning: Should use valueOf instead of new. r=geckoview-reviewers,calu

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/19d8c3a76b9c