Closed
Bug 1510700
Opened 6 years ago
Closed 6 years ago
Discovery.jsm's 'update()' calls into ContextualIdentityService which can then do main-thread IO
Categories
(Toolkit :: Add-ons Manager, enhancement, P1)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: Gijs, Assigned: mixedpuppy)
References
Details
(Keywords: main-thread-io, Whiteboard: [fxperf])
Attachments
(1 file)
Discovery.jsm should wait for ContextualIdentityService.jsm to have loaded its data file async.
Profile in which this shows up:
http://bit.ly/2DOXYOJ
Warning: I haven't checked how much whack-a-mole this is going to be, ie if we fix this callsite, does something else try to access CIS sync? Only one way to find out...
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Component: General → Add-ons Manager
Product: WebExtensions → Toolkit
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mixedpuppy
Priority: -- → P1
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/db4247c27127
wait for ContextualIdentityService before updating Discovery cookies r=Gijs
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•