Closed
Bug 1510749
Opened 6 years ago
Closed 6 years ago
ARM64: Allow CSINC to accept WZR/XZR
Categories
(Core :: JavaScript Engine: JIT, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
1.21 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
VIXL prevents the 2nd and 3rd registers in CSINC from being WZR/XZR, but the AArch64 ISR explicitly allows that, and in fact the VIXL codegen internally calls (the assembler variant, without assertions, of) CSINC with WZR. The assertions are commented-out instead of being deleted because the change needs to be propagated when we eventually upgrade to a recent VIXL release. Fixes ion/bug1140890.js and a bunch of other failures.
Attachment #9028422 -
Flags: review?(jitbugs)
|
||
Updated•6 years ago
|
Attachment #9028422 -
Flags: review?(jitbugs) → review?(nicolas.b.pierron)
|
|
||
Updated•6 years ago
|
status-firefox65:
--- → fix-optional
Priority: -- → P2
|
|
||
Comment 1•6 years ago
|
||
Comment on attachment 9028422 [details] [diff] [review] 0001-The-AArch64-ISR-explicitly-allows-CSINC-to-accept-ZR.patch Review of attachment 9028422 [details] [diff] [review]: ----------------------------------------------------------------- I would add that CSET and CINC are aliases of CSINC instruction which are explicitly making use of the XZR register.
Attachment #9028422 -
Flags: review?(nicolas.b.pierron) → review+
|
Assignee | |
Comment 2•6 years ago
|
||
Thanks! Added comment about CSET, carrying r+. CINC does accept WZR/XZR but isn't defined in terms of CSINC with WZR/XZR as CSET is.
Attachment #9028422 -
Attachment is obsolete: true
Attachment #9029014 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c17ac872bdf The AArch64 ISR explicitly allows CSINC to accept ZR. r=nbp
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6c17ac872bdf
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•