1510811 - On-boarding prevents FxA deep-linking from working

Status: NEW

(Firefox for iOS :: Firefox Accounts, defect, P3)

Description

[Ryan Kelly [:rfkelly]]

Migrating this from https://github.com/mozilla/fxa-content-server/issues/6642 as we suspect it may be a client-side issue.  Original description from Alex, lightly edited by me to add context:

"""
During Sync Fest today, we went through the registration flow.

We were unable to get the SMS deeplinking to work. It is my understanding that it doesn't normally work twice on the same phone but I was using a new phone so I thought it would work.

Steps to reproduce

* register for an account an desktop device
* click email link to confirm account
* on the resulting post-verification screen, send an SMS to install Firefox for iOS
* receive SMS on a fresh iOS device
* open SMS and Firefox for iOS through the App Store
* Open Firefox for iS
    open app

Expected result
User sees the FxA login form with their email prepopulated

Actual result
User is sent to regular onboarding flow
"""

Comment 1

[Ryan Kelly [:rfkelly]]

Also worth noting, this can be hard to test as the deeplinking flow only works once per device by default; in order to test multiple times on a single device you need to able to clear your advertizing id from adjust as described here:

  https://github.com/mozilla/fxa-content-server/issues/6642#issuecomment-430734467

Comment 2

[Ryan Kelly [:rfkelly]]

Sorina, did you end up getting adjust access after the discussion here?

  https://github.com/mozilla/fxa-content-server/issues/6642#issuecomment-432573691

Comment 3

[Ryan Kelly [:rfkelly]]

We wondered if this might be some adjust config fallout from the recent change to use https://confirm.accounts.firefox.com rather than https://accounts.firefox.com as the "app link" domain for the Firefox for iOS app.

Comment 4

[Sorina Florean [:sflorean]]

(In reply to Ryan Kelly [:rfkelly] from comment #2)
> Sorina, did you end up getting adjust access after the discussion here?
> 
>  
> https://github.com/mozilla/fxa-content-server/issues/6642#issuecomment-
> 432573691

I've requested a demo in order to create an Adjust account. I'm waiting for updates. Other news on this problem I don't have.

Comment 5

[Ryan Kelly [:rfkelly]]

Stefan, is there anything you can do to help Sorina with Adjust access?

Comment 6

[Catalin Suciu [:csuciu]]

I was able to reproduce this issue on a new device (iPhone XS running iOS 12).

Following the STRs from the description I was sent to the onboarding flow instead of seeing the FxA login form.

Next, going to the Onbording sync panel and tapping on Sign In shoes the   to the FxA sign in page from the Onbording sync panel shows the email address pre-filled.

Comment 7

[Catalin Suciu [:csuciu]]

Please disregard the previous comment.

I was able to reproduce this issue on a new device (iPhone XS running iOS 12).

Following the STRs from the description I was sent to the onboarding flow instead of seeing the FxA login form.

Next, going to the Onbording sync panel and tapping on Sign In button shows the FxA Sign In page with the email address pre-filled.

Comment 8

[Shane Tomlinson [:stomlinson]]

> Next, going to the Onbording sync panel and tapping on Sign In button shows the FxA Sign In page with the email address pre-filled.

:vbudhram - I haven't played with Firefox for iOS for a long time, but IIRC, this is the expected behavior isn't it?
I remember needing to scroll through onboarding or clicking the sign in button before the FxA form would appear.

Comment 9

[Vijay Budhram]

> this is the expected behavior isn't it?

This was how it worked originally (and should still work), but was also modified to have sign-in screen appear before on-boarding in [1]. That was an attempt to fix some of the inconsistent results with deferred deeplinking.


[1] - https://github.com/mozilla-mobile/firefox-ios/pull/3020

Comment 10

[Justin D'Arcangelo [:justindarc]]

Re-naming the title of this bug to more accurately describe the issue here.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jeevans, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:jeevans, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.