Closed Bug 1510829 Opened 7 years ago Closed 7 years ago

Negative heap-unclassified assertion prevents DMD report from being generated

Categories

(Testing :: AWSY, enhancement)

Product:
Testing
Component:
AWSY
Version:
Version 3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: bholley, Assigned: erahm)

Details

Attachments

(1 file)

Upload AWSY artifacts even if processing fails
2.89 KB, patch
bc
: review+
Details | Diff | Splinter Review
See bug 1507912 comment 5 and onward.
It's useful to get DMD reports even if we end up with negative heap-unclassified. This catches any assertions during processing and makes sure we move the reports to the upload dir even if there's a failure.
Attachment #9029326 - Flags: review?(bob)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 9029326 [details] [diff] [review] Upload AWSY artifacts even if processing fails Review of attachment 9029326 [details] [diff] [review]: ----------------------------------------------------------------- r+. lgtm.
Attachment #9029326 - Flags: review?(bob) → review+
For posterity I did a try run [1] that explicitly failed the heap-unclassified assertion and reports were still uploaded as artifacts. [1] https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=215316820&revision=8edd04482ca54442dd209b8613e7a698c817e8a2
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5297d3b97f2a Upload AWSY artifacts even if processing fails. r=bc
https://hg.mozilla.org/mozilla-central/rev/5297d3b97f2a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: