1510942 - No caret in formula bar of Google sheets (mispositioned caret)

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[Alice0775 White]

Reproducible the issue on Firefox, but not on Edge and Chrome.

Steps To Reproduce:
1. Logged in Google
2. Open https://docs.google.com/spreadsheets/
   And start a new spreadsheet
3. Click on empty field of formula bar(fx)

Actual Results:
No caret display, but I can type characters.

Expected Results:
Caret should be blinking.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Is this a recent regression? I suspect it may have regressed with bug 1506547.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Testcase.

Not a regression, but slightly bizarre bug. If you remove the overflow: hidden ancestor you can see that the caret is mispositioned.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I can see what's going wrong.

Comment 4

[Alice0775 White]

Regression window with the attachment 9028583 [details]:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f7c89de3ab43&tochange=3f0587ce1774

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1510942 - Fix the position of the caret when the caret frame is a reference frame.

This is consistent with what we do for non-stacking-contexts. The
GetCaretFrame() == child check may be able to go away, I'm not sure, so I've
left it for now.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(In reply to Alice0775 White from comment #4)
> Regression window with the attachment 9028583 [details]:
> 
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=f7c89de3ab43&tochange=3f0587ce1774

-> bug 788044, fairly sure.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1894e5ca0523
Fix the position of the caret when the caret frame is a reference frame. r=mattwoodrow

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1894e5ca0523

Comment 9

[Sayed [:LiquidO2]]

I can reproduce this issue with 65.0a1 (2018-11-29) (64-bit) in Linux x86_64

I am verifying that this issue is now fixed in latest beta 65.0b10

Build ID: 20190110221328
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0