1510973 - Java Warning: Redundant Local Variable

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Reports unnecessary local variables, which add nothing to the comprehensibility of a method. Variables caught include local variables which are immediately returned, local variables that are immediately assigned to another variable and then not used, and local variables which always have the same value as another local variable or parameter.

Affected Classes

AtomParsers
GeckoHLSDemuxerWrapper
GeckoHlsPlayer
GeckoMediaDrmBridgeV21
IntentUtils
MediaDrmProxy

Comment 1

[clairebitterness]

Hello! can you assign me this bug? I would like to work on this

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Hi clairebitterness, sure thing. There are good docs to get you started here: https://mozilla.github.io/geckoview/tutorials/geckoview-quick-start.html

You can run the lint using ./mach android lint after you set up the workspace using the guide linked above.

Feel free to ask me any questions here on the bug or on IRC at #mobile.

Comment 3

[Jimmy Tan]

Hey I don't know if this bug is fixed yet, if not can I work on it?

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Hi Jimmy! This bug is not fixed yet, we usually ask first time contributors to attach a patch before assigning bugs. Let me know if you need any help with that or something else!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 6

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 7

[Logan Rosen [:Logan]]

Attachment: Bug 1510973 - remove redundant local variables r?#geckoview-reviewers

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b39dd7670b6b
remove redundant local variables r=geckoview-reviewers,calu

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b39dd7670b6b