1511012 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.webapps.WebApps.getValidURL(WebApps.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-35b4e3b9-a7d0-4238-bb08-211f70181129.
=============================================================

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.webapps.WebApps.getValidURL(WebApps.java:77)
	at org.mozilla.gecko.customtabs.CustomTabsActivity.onContextMenu(CustomTabsActivity.java:704)
	at org.mozilla.geckoview.GeckoSession$2.handleMessage(GeckoSession.java:375)
	at org.mozilla.geckoview.GeckoSession$2.handleMessage(GeckoSession.java:356)
	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:79)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6501)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

There are 3 crashes (from 3 installations) in nightly 65 with buildid 20181128100103. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1509266.

[1] https://hg.mozilla.org/mozilla-central/rev?node=a729f76f6aae

Comment 1

[Chris Peterson [:cpeterson]]

P1 because this is a crash and a regression.

Comment 2

[Eugen Sawin [:esawin]]

That doesn't look like a recent regression, I'm seeing the signature on versions as old as 63.

Comment 3

[Calixte Denizet (:calixte)]

According to crash-stats there is no crash with this signature in the last 6 months on nightly (except for the two last releases).

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Bug 1511012 - [1.0] Ensure non-null scheme before accessing it. r=droeh!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea4b9bbb0cf4
[1.0] Ensure non-null scheme before accessing it. r=droeh

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ea4b9bbb0cf4

Comment 7

[Chris Peterson [:cpeterson]]

Assuming 64=unaffected until we see this crash signature during Focus 8.0 testing:

https://crash-stats.mozilla.com/search/?product=Focus&version=64.0b