1511095 - Drop tab throbber frame rate to 30fps by default

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Originally, this was something we were going to roll into bug 1503339 for users with 2 or fewer CPU cores, since the SHIELD study data[1] we pulled suggested that this really only has an impact on users that are CPU constrained.

jaws brought up a good point in IRC - while it's nice to specifically target the users that will be impacted the most with a lower FPS throbber, it adds maintenance burden and complexity to have the two states. Why not just lower the FPS on the throbber for everybody?

Bug 1503339 can then be more concerned with lower the global framerate.


[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1462158#c22

Comment 1

[Mike Conley (:mconley) (:⚙️)]

The only argument against is that there might be less perceived smoothness of the tab throbber due to the missing frames, although jaws points out that this is a pretty small animation, and that the difference in smoothness is likely not very perceivable.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

What do you think of this, Gijs? This would also simplify your work in bug 1503339 a bit, right?

Comment 3

[:Gijs (he/him)]

If UX is happy with this, wfm!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey epang,

So we're considering dropping the tab loading throbber framerate down to 30fps by default. Any objections from UX's side? You can test what it'll look like in Nightly on all desktop platforms by setting browser.tabs.30FpsThrobber to true and restarting the browser.

Comment 5

[Eric Pang [:epang] UX]

wfm, barely noticeable at the size it is. Thanks for checking in :)

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1511095 - Remove support for 20fps throbber. r?mconley

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1511095 - Remove SchedulePressure.jsm and the fallback loading throbber in the tabstrip. r?mconley

The APNG version is still used by the TabsList which can't support the SVG version of the throbber currently.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1511095 - Remove support for the 30fps pref, and replace the loading.svg with the 30fps variant. r?mconley

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Baseline try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee0817d6f883ae4eeb2d66c2128bf0704a92c9c3

Try push with patches:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0012207680cefcbd643d91f38bd66f341b08cda3

Compare Talos:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=ee0817d6f883ae4eeb2d66c2128bf0704a92c9c3&newProject=try&newRevision=0012207680cefcbd643d91f38bd66f341b08cda3&framework=1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/227e4c466232
Remove support for 20fps throbber. r=mconley
https://hg.mozilla.org/integration/autoland/rev/fc79d3717e40
Remove SchedulePressure.jsm and the fallback loading throbber in the tabstrip. r=mconley
https://hg.mozilla.org/integration/autoland/rev/0ceb5c6cc6b0
Remove support for the 30fps pref, and replace the loading.svg with the 30fps variant. r=mconley

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/227e4c466232
https://hg.mozilla.org/mozilla-central/rev/fc79d3717e40
https://hg.mozilla.org/mozilla-central/rev/0ceb5c6cc6b0

Comment 12

[Ionuț Goldan [:igoldan]]

Noticed some perf improvements:

== Change summary for alert #17946 (as of Thu, 29 Nov 2018 20:27:52 GMT) ==

Improvements:

  6%  Images opt stylo     5,640,945.38 -> 5,286,377.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17946

Comment 13

[Ionuț Goldan [:igoldan]]

And another one from Raptor:

== Change summary for alert #17942 (as of Thu, 29 Nov 2018 23:00:02 GMT) ==

Improvements:

  3%  raptor-tp6-slides-firefox opt      1,407.00 -> 1,357.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17942