1511102 - The about:performance table should be updated immediately when switching back to the tab

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, enhancement)

Description

[Florian Quèze [:florian]]

It's currently pretty common that when leaving about:performance open in a tab and switching back to it later, it looks broken because it takes several seconds to refresh. This happens because the refresh happens every 2s using a timer. This leaves 2s for the user to move the mouse above the table and trigger the "don't refresh for 5s after a mouse event" case we added to prevent closing the wrong tab. So if the user moves the mouse over the table within the first 2s after switching back to the tab, it'll take 6s before it updates... if the user stops moving the mouse. If the user gets impatient and keeps nervously moving the mouse, it'll never update.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9028711 [details] [diff] [review]
Patch

Review of attachment 9028711 [details] [diff] [review]:
-----------------------------------------------------------------

What does this do right after the page loads? Will it not trigger a double update?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9028711 [details] [diff] [review]
Patch

Review of attachment 9028711 [details] [diff] [review]:
-----------------------------------------------------------------

Preemptive r+ if you make sure it doesn't cause a double update at the beginning.

Comment 4

[Florian Quèze [:florian]]

(In reply to :Felipe Gomes (needinfo me!) from comment #2)
> Comment on attachment 9028711 [details] [diff] [review]
> Patch
> 
> Review of attachment 9028711 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> What does this do right after the page loads? Will it not trigger a double
> update?

There's already a double update due to https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/toolkit/components/aboutperformance/content/aboutPerformance.js#1472-1473 that I should remove when removing the code of the old about:performance.

I've verified that this patch doeesn't cause a third update near page load.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/526d733d3c62
update the about:performance table immediately when switching back to the tab, r=felipe.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/526d733d3c62