151114 - Support nsIAccessibleHyperLink in MAI (Mozilla Atk Implementation)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Bolian Yin]

Comment 1

[Bolian Yin]

Attachment: patch_v1

nsIAccessibleHyperLink is different with other nsIAccessibleXXX interfaces in
that is a auxiliary interface for nsIAccessibleHyperText. So a
nsIAccessibleHyperLink instance is not necessarily a nsIAccessible. In face, in
atk atkhyperlink is a GObject while atkhypertext, atkaction, atktext, etc. are
GTypeInterface's.

Comment 2

[Bolian Yin]

Attachment: patch_v2 (move callbacks into C namespace)

Comment 3

[Kyle Yuan]

-> gilbert

Comment 4

[Gilbert Fang]

Comment on attachment 88434 [details] [diff] [review]
patch_v2 (move callbacks into C namespace)

>+
>+static gpointer parent_class = NULL;
>+
Is there any possibility to change the name of "parent_class" to
"super_class_AtkHyperlink"?


>+
>+MaiHyperlink::MaiHyperlink(nsIAccessibleHyperLink *aAcc)
>+{
>+    mHyperlink = aAcc;
>+    mMaiAtkHyperlink = NULL;
>+    mURI = (char*)NULL;
>+}
Would it be better if  aAcc is changed to aAccHyperLink?

>+    MaiHyperlink::Initialize(mMaiAtkHyperlink, this);
>+
>+    return (AtkHyperlink*)mMaiAtkHyperlink;
If the caller or AtkHyperlink itself can manage the life cycle itself, it is
okay here.  
>+
>+    MaiObject *maiObj = maiHyperlink->GetObject(aLinkIndex);
>+    if (!maiObj)
>+        return NULL;
>+
>+    //no need to add ref it, because it is "get" not "ref" ???
>+    return maiObj->GetAtkObject();
>+}
It must be sure this maiObj will be released somewhere when it should be .

Comment 5

[Gilbert Fang]

Other parts of this patch  is  okay from my view.

Comment 6

[Bolian Yin]

Thanks, Gilbert. 
The lifecycle of mai object and mai Hyperlink will be controled by maiCache
(later), I will be careful on that, and you are welcome to check it later.
I see your point of variable names, but their usage are all restricted in narrow
scope, so their meaning is clear in the context :). 

Comment 7

[Bolian Yin]

Attachment: patch_v3

comments in bug 151133 hold here

Comment 8

[Bolian Yin]

Attachment: patch v4

make return statement simpler

Comment 9

[Aaron Leventhal]

Comment on attachment 89244 [details] [diff] [review]
patch v4

r=aaronl

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 89244 [details] [diff] [review]
patch v4

sr=jst

Comment 11

[Bolian Yin]

Checked in! Thanks for everyone!