Closed Bug 1511141 Opened 10 months ago Closed 10 months ago

Disable formatting for more MOZ_COLLECT_REPORT calls

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Some of the uses of MOZ_COLLECT_REPORT involve very large string constants, which get rewrapped in an ugly fashion by clang-format. This code has already opted out of existing Mozilla style by ignoring indentation, so let's just disable it.

Here's an example of this:

      MOZ_COLLECT_REPORT(
        "vsize", KIND_OTHER, UNITS_BYTES, amount,
"Memory mapped by the process, including code and data segments, the heap, "
"thread stacks, memory explicitly mapped by the process via mmap and similar "
"operations, and memory shared with other processes. This is the vsize figure "
"as reported by 'top' and 'ps'.  This figure is of limited use on Mac, where "
"processes share huge amounts of memory with one another.  But even on other "
"operating systems, 'resident' is a much better measure of the memory "
"resources used by the process.");

I've gone through all of the uses of the macro, and disabled formatting for the places that have big descriptions.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f64401a8c87
Disable formatting for more MOZ_COLLECT_REPORT calls. r=erahm
https://hg.mozilla.org/mozilla-central/rev/2f64401a8c87
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9028762 [details]
Bug 1511141 - Disable formatting for more MOZ_COLLECT_REPORT calls.

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a comment only change.

String or UUID changes made by this patch: None
Attachment #9028762 - Flags: approval-mozilla-esr60?
Thanks for dealing with the uplift requests for all of these patches, Ehsan!
Comment on attachment 9028762 [details]
Bug 1511141 - Disable formatting for more MOZ_COLLECT_REPORT calls.

OK for uplift to ESR for clang-format project.
Attachment #9028762 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
(In reply to Andrew McCreight [:mccr8] (PTO-ish 12-10 to -14) from comment #5)
> Thanks for dealing with the uplift requests for all of these patches, Ehsan!

My pleasure.  :-)
You need to log in before you can comment on or make changes to this bug.