151122 - Email prefs: Reporter / Owner messed up

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Jouni Heikniemi]

On the email prefs page the assignee and owner columns have their labels (or
contents, whichever way you want to look at it) swapped. 

Patch incoming. Ccing Gerv for review, this is his code originally.

Comment 1

[Jouni Heikniemi]

Attachment: v1

Swaps the column contents.

Comment 2

[Jouni Heikniemi]

Let's get this into the branch as well, it's a templatization regression.

Comment 3

[Andreas Franke (gone)]

You mean "Reporter" and "Owner" are swapped. Are you sure that it's better the
way it was before? I think having owner and qacontact side makes sense, and
reporter is much more related to cclist than to owner and qacontact, so if you
swap it, you may want to put it after qacontact, not before.

Comment 4

[Jouni Heikniemi]

Reporter and Owner, naturally. My apologies.

As for changing the column order: what you say makes sense, but is a subject for
another bug; the intention of this quick fix is to remedy the problem with table
headings and contents being misaligned. We can argue about the correct pref
order later.

Note that the visible order has been reporter-owner-qa-cc-voter all the time;
this doesn't change that. 

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 87342 [details] [diff] [review]
v1

r=bbaetz

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 87342 [details] [diff] [review]
v1

r=gerv. Jouni - can you check this in?

Gerv

Comment 7

[Jouni Heikniemi]

Gerv: Nah, I haven't got the time to apply for commit access. So if you please...

Comment 8

[Gervase Markham [:gerv]]

Checked on on trunk and branch.

Checking in ./template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

Checking in ./template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.3; previous revision: 1.2
done

Gerv