Closed Bug 1511285 Opened 9 months ago Closed 9 months ago

Make 'mach clang-format' more efficient when outputting to stdout

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(1 file)

Since 'mach clang-format' outputting to stdout is mostly used during mergers we need to make this process more reliable and faster so this patch adds the following:
1. Avoid the hassle of utf8 conversion when outputting to console.
2. Do not output to console the entire file when it doesn't need to be reformat. This is for 3rd party.
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/bf92aff5b93d
Make 'mach clang-format' more efficient when outputting to stdout. r=ehsan, a=aryx
Pushed by emilio@crisal.io:
https://hg.mozilla.org/mozilla-central/rev/138f65958545
followup: Properly wait for the child process. r+a=Andi
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.