Closed
Bug 151134
Opened 22 years ago
Closed 22 years ago
support nsIAccessibleEditableText in MAI (Mozilla Atk Implementation)
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: yinbolian, Assigned: yinbolian)
References
Details
(Keywords: access)
Attachments
(1 file, 3 obsolete files)
|
13.11 KB,
patch
|
aaronlev
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•22 years ago
|
|
|
Assignee | |
Comment 1•22 years ago
|
||
comments in bug 151133 hold here
|
|
Assignee | |
Comment 2•22 years ago
|
||
Attachment #89223 -
Attachment is obsolete: true
|
||
Comment 3•22 years ago
|
||
These lines are creating code in release builds. I think you only want these
checks in debug builds:
+ if (NS_FAILED(rv))
+ MAI_LOG_WARNING(("MaiInterfaceEditableText::copyText, failed\n"));
+
Perhaps you want NS_WARN_IF_FALSE() or NS_ASSERTION or something of that nature.
That way the code only compiles in debug builds.|
|
Assignee | |
Comment 4•22 years ago
|
||
Attachment #89224 -
Attachment is obsolete: true
|
|
||
Comment 5•22 years ago
|
||
I still see
+ if (NS_FAILED(rv))
+ MAI_LOG_WARNING(("MaiInterfaceEditableText::InsertText, failed\n"));
+
|
|
Assignee | |
Comment 6•22 years ago
|
||
Attachment #89250 -
Attachment is obsolete: true
|
|
||
Comment 7•22 years ago
|
||
Comment on attachment 89355 [details] [diff] [review] patch_v3 (sorry, this one is clear) r=aaronl
Attachment #89355 -
Flags: review+
|
|
Assignee | |
Comment 8•22 years ago
|
||
This bug has been checked in. It is not in the default build and we need it to do later work. Further comments, review, and super-review is still welcome, I will file new bug if needed. Thanks for everyone.
|
|
Assignee | |
Comment 9•22 years ago
|
||
=>Fix
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•