Closed Bug 1511375 Opened 6 years ago Closed 6 years ago

The horizontal scroll bar is out of place

Categories

(Core :: Panning and Zooming, defect, P1)

Product:
Core
Component:
Panning and Zooming
Version:
65 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- fixed

People

(Reporter: csheany, Assigned: botond)

References

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot_20181130-103031.jpg
170.85 KB, image/jpeg
Details
Bug 1511375 - Update the visual viewport size in UpdateResolution() if either the zoom or the display size might have changed. r=kats
47 bytes, text/x-phabricator-request
Details | Review 
User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:65.0) Gecko/65.0 Firefox/65.0

Steps to reproduce:

1. Open https://github.com/mozilla-mobile
2. Request desktop site
3. Zoom in
4. Scroll down


Actual results:

The scroll bar appears higher than it is supposed to.


Expected results:

The scroll bar should be closer to the edge.

    
  
Summary: The vertical sroll bar is out of place → The horizontal sroll bar is out of place

    
    

    
  
Regression range points to bug 1509552, confirmed via local backout.
Assignee: nobody → botond
Blocks: 1509552
Summary: The horizontal sroll bar is out of place → The horizontal scroll bar is out of place

    
  
Component: General → Panning and Zooming
Product: Firefox for Android → Core
Version: Firefox 65 → 65 Branch

    
  
Priority: -- → P1

    
    

    
  
(In reply to Botond Ballo [:botond] from comment #2)
> Regression range points to bug 1509552

Specifically, the second patch.

I bet things were relying on UpdateVisualViewportSize() being called in cases where the resolution didn't change but the display size did, as happens when the dynamic toolbar transitions on- or offscreen.

    
    

    
  
(In retrospect, it's obvious that we need to update the visual viewport size if either the resolution or the display size changes, as it's a function of both, and this is the only place we update it.)

    
    

    
  
Should the scroll bar be visible when the keyboard is displayed?

    
    

    
  
(In reply to csheany from comment #6)
> Should the scroll bar be visible when the keyboard is displayed?

I would say yes, since you can still scroll the page while the keyboard is displayed.

    
    

    
  
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b12e6afd5831
Update the visual viewport size in UpdateResolution() if either the zoom or the display size might have changed. r=kats
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b12e6afd5831
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox65:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: