1511375 - The horizontal scroll bar is out of place

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P1)

Description

[csheany]

User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:65.0) Gecko/65.0 Firefox/65.0

Steps to reproduce:

1. Open https://github.com/mozilla-mobile
2. Request desktop site
3. Zoom in
4. Scroll down


Actual results:

The scroll bar appears higher than it is supposed to.


Expected results:

The scroll bar should be closer to the edge.

Comment 1

[csheany]

Attachment: Screenshot_20181130-103031.jpg

Comment 2

[Botond Ballo [:botond]]

Regression range points to bug 1509552, confirmed via local backout.

Comment 3

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #2)
> Regression range points to bug 1509552

Specifically, the second patch.

I bet things were relying on UpdateVisualViewportSize() being called in cases where the resolution didn't change but the display size did, as happens when the dynamic toolbar transitions on- or offscreen.

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1511375 - Update the visual viewport size in UpdateResolution() if either the zoom or the display size might have changed. r=kats

Comment 5

[Botond Ballo [:botond]]

(In retrospect, it's obvious that we need to update the visual viewport size if either the resolution or the display size changes, as it's a function of both, and this is the only place we update it.)

Comment 6

[csheany]

Should the scroll bar be visible when the keyboard is displayed?

Comment 7

[Botond Ballo [:botond]]

(In reply to csheany from comment #6)
> Should the scroll bar be visible when the keyboard is displayed?

I would say yes, since you can still scroll the page while the keyboard is displayed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b12e6afd5831
Update the visual viewport size in UpdateResolution() if either the zoom or the display size might have changed. r=kats

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b12e6afd5831