1511393 - Update Emacs mode line to use 2-spaces indent

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Tooru Fujisawa [:arai]]

Given we stopped using 4-spaces indentation in js/, Emacs mode line needs to be updated
(or the mode line needs to be removed?)

Comment 1

[Tom Tromey :tromey]

See bug 1023839 for a different approach based on removing the lines.

Comment 2

[Mark Banner (:standard8)]

xref bug 1511383 comment 4

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Use c-basic-offset: 2 in Emacs mode line for C/C++ code.

Replaced "c-basic-offset: 4" with "c-basic-offset: 2", by:
  * grepped "c-basic-offset: 4"
  * filtered only to C/C++ code (.cpp, .c, .h, .mm, .m)
  * filtered .clang-format-ignore patterns out
  * replaced the line with sed

I agree that it's better discuss about the future, whether to use mode line,
but this helps a lot when editing those files meanwhile.

Comment 4

[Tooru Fujisawa [:arai]]

actually, not js/ specific patch

Comment 5

[Nicolas B. Pierron [:nbp] {away}]

Comment on attachment 9029004 [details] [diff] [review]
Use c-basic-offset: 2 in Emacs mode line for C/C++ code.

Review of attachment 9029004 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me.

Comment 6

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66eb1f485c1a3ea81372758bc92292c9428b17cd
Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/66eb1f485c1a