Closed Bug 1511393 Opened 6 years ago Closed 6 years ago

Update Emacs mode line to use 2-spaces indent

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

enhancement
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Given we stopped using 4-spaces indentation in js/, Emacs mode line needs to be updated (or the mode line needs to be removed?)
See bug 1023839 for a different approach based on removing the lines.
Replaced "c-basic-offset: 4" with "c-basic-offset: 2", by: * grepped "c-basic-offset: 4" * filtered only to C/C++ code (.cpp, .c, .h, .mm, .m) * filtered .clang-format-ignore patterns out * replaced the line with sed I agree that it's better discuss about the future, whether to use mode line, but this helps a lot when editing those files meanwhile.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #9029004 - Flags: review?(sledru)
actually, not js/ specific patch
Summary: Update Emacs mode line to use 2-spaces indent in js/ → Update Emacs mode line to use 2-spaces indent
Comment on attachment 9029004 [details] [diff] [review] Use c-basic-offset: 2 in Emacs mode line for C/C++ code. Review of attachment 9029004 [details] [diff] [review]: ----------------------------------------------------------------- Sounds good to me.
Attachment #9029004 - Flags: review?(sledru) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Target Milestone: Firefox 65 → mozilla65
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: