1511414 - Add hook or test to prevent generated parser code from being broken

Status: NEW

(Developer Infrastructure :: Lint and Formatting, enhancement, P3)

Description

[Jonathan Kingston [:jkt] he/him]

Bug 1425874 along with many others have changed the java generated files (no blame I have tried this before too).

The latest breakage are the difference between these two:
https://bug903372.bmoattachments.org/attachment.cgi?id=9018872
https://bug903372.bmoattachments.org/attachment.cgi?id=9028944

Can we do something like vendoring a java test or even just a phab hook to flag a parser peer?

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

NI Henri for questions on comment 0. :)

Comment 2

[Henri Sivonen (:hsivonen)]

Moving to the Phabricator component.

The simplest thing that could possibly work would be a hook that whines to the patch author if parser/html/nsHtml5Foo.[cpp|h] was changed but parser/html/javasrc/Foo.java was not also changed (for cases where Foo.java exists).

A more complex solution, which would depend on having OpenJDK in automation, would be actually running the "make translate" step described in https://searchfox.org/mozilla-central/source/parser/html/java/README.txt in automation followed by clang-format and checking that nothing changes.

Comment 3

[:glob ✱]

i don't think this is something that phabricator can check directly.
it sounds more like something for reviewbot or a normal test.

marco - do you think reviewbot could catch this during its analysis?

Comment 4

[Marco Castelluccio [:marco]]

If somebody implements a new checker based on one of the two solutions Henri suggested, we could add it to our reviewbot.

Moving to Firefox Build System::Lint and Formatting, which seems like a better component for this.

Adding a new checker is not hard, see for example https://hg.mozilla.org/mozilla-central/rev/3eefd4e1087c.