Closed Bug 1511525 Opened 10 months ago Closed 9 months ago

Consider RunToPoint messages when determining where a child process is

Categories

(Core :: Web Replay, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
ChildProcessInfo::GetDisposition() does not consider RunToPoint messages when determining where a child process is located.  This causes problems after warping to a point near the beginning of the recording, where the debugger refuses to change its position when rewinding or reverse stepping.

ChildProcessInfo::GetDisposition() is kind of antique code from back when we didn't have a way to identify the execution points where a child process is paused.  It's going to get removed very soon but it seemed better to fix this first because it causes incorrect behavior.
Attachment #9029092 - Flags: review?(continuation)
Attachment #9029092 - Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7206ae930051
Consider RunToPoint messages when determining where a child process is, r=mccr8.
https://hg.mozilla.org/mozilla-central/rev/7206ae930051
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.