Closed
Bug 1511525
Opened 6 years ago
Closed 6 years ago
Consider RunToPoint messages when determining where a child process is
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
582 bytes,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
ChildProcessInfo::GetDisposition() does not consider RunToPoint messages when determining where a child process is located. This causes problems after warping to a point near the beginning of the recording, where the debugger refuses to change its position when rewinding or reverse stepping.
ChildProcessInfo::GetDisposition() is kind of antique code from back when we didn't have a way to identify the execution points where a child process is paused. It's going to get removed very soon but it seemed better to fix this first because it causes incorrect behavior.
Attachment #9029092 -
Flags: review?(continuation)
Updated•6 years ago
|
Attachment #9029092 -
Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7206ae930051
Consider RunToPoint messages when determining where a child process is, r=mccr8.
Comment 2•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•