1511638 - Recurring events put days in wrong week if week start setting is not Monday

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Emerson Prado]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

I set Calendar week start to Sunday, Monday and Tuesday. Then, in each setting, I created two events recurring every 3 weeks.
One event contained only days which fell in the same week, considering both the week start set and Monday. The other span over days which fell in different weeks depending on this setting.

Build ID: 20181122140626
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1
OS: Linux 4.18.16-300.fc29.x86_64
Lightning Version ID: e2fda1a4-762b-4020-b5ad-a41df1933103
Libraries:
    NSPR 	4.20
    NSS 	3.39
    NSSSMIME 	3.39
    NSSSSL 	3.39
    NSSUTIL 	3.39


Actual results:

With weekstart on Sunday:
- Recurrence on all weekdays but Sunday: OK
- Recurrence including Sunday: all weekdays but Sunday shifted to earlier week

With weekstart on Tueday:
- Recurrence on weekdays but Monday: OK
- Recurrence including Monday: all weekdays but Monday shifted to earlier week

With weekstart on Monday:
- Recurrence with any weekday: OK

This happened over 10 years ago in Sunbird:
https://bugzilla.mozilla.org/show_bug.cgi?id=331112
https://bugzilla.mozilla.org/show_bug.cgi?id=383039


Expected results:

All events should appear in the correct week.

Comment 1

[Emerson Prado]

Attachment: Calendar to be viewed with week start on Sunday

Comment 2

[Emerson Prado]

Attachment: Calendar to be viewed with week start on Monday

Comment 3

[Emerson Prado]

Attachment: Calendar to be viewed with week start on Tuesday

Comment 4

[Emerson Prado]

Problem also observed in a different machine, with different Thunderbird and Calendar versions:

Build ID: 20180714091212
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
Lightning version: 5.4
Lightning Version ID: e2fda1a4-762b-4020-b5ad-a41df1933103
Libraries:
    NSPR 	4.13.1
    NSS 	3.28.6
    NSS Util 	3.28.6
    NSS SSL 	3.28.6
    NSS S/MIME 	3.28.6

This is a Linux Mint Debian Edition - LMDE2 Betsy. The one in the bug description is a Fedora 29.

Comment 5

[Thatoo]

Attachment: Erro for repeat event week starting saturday

Comment 6

[Thatoo]

I encounter the same error.
I set the week to start saturday.
I wanted to add a recurring event happening every two weeks on saturday, sunday and monday but as you can see on the screen shot, the selected monday is the one of wrong week as if Lightning was still set to week starting on monday...
Thank you Emerson Prado to open this issue 4 years ago. This issue is still there on Thunderbird 91.10.

Comment 7

[Sean Burke [:leftmostcat]]

Attachment: Bug 1511638 - set week start when creating recurrence rule. r=#thunderbird-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/255936857dbf
set week start when creating recurrence rule. r=mkmelin