Closed Bug 1511805 Opened 6 years ago Closed 5 years ago

URL bar code shouldn't alter DOM in promiseDocumentFlushed()

Categories

(Firefox :: Address Bar, enhancement, P1)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: Gijs, Assigned: mconley)

References

Details

(Keywords: perf, Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1511805 - Don't alter DOM inside of promiseDocumentFlushed used by urlbarBindings.xml. r?mak
47 bytes, text/x-phabricator-request
Details | Review 
I reviewed this so I it's my own fault, but altering the DOM from within the promiseDocumentFlushed() call isn't allowed.

https://searchfox.org/mozilla-central/rev/2edebf41a2b2e624859bf15ed5a98bdd002f73b4/browser/base/content/urlbarBindings.xml#1382

I don't know what the constraints are for how quickly we need to set this attribute and if we can just stick it in a requestAnimationFrame or if we should await the promise, or something else.
Note that we should also fix browser/components/urlbar/UrlbarInput.jsm in the same way, of course.
I think we can wait for animation frame, provided we check overflow status like we do now before setting the attribute
Priority: -- → P1
Whiteboard: [fxsearch]
Keywords: perf
Blocks: 1441168
No longer depends on: 1441168
Assignee: nobody → mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f41e4d6e5592
Don't alter DOM inside of promiseDocumentFlushed used by urlbarBindings.xml. r=mak
https://hg.mozilla.org/mozilla-central/rev/f41e4d6e5592
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: