Simplify @media not all and (-moz-os-version: ...) queries

RESOLVED FIXED in Firefox 65

Status

()

P3
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: dao, Assigned: andrewc.goupil, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 65
All
Windows
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
These media queries use an old syntax:

https://searchfox.org/mozilla-central/search?q=%40media+not+all+and+(-moz&case=true&regexp=false

With Media Queries Level 4, instead of:

  @media not all and (-moz-os-version: ...) {

we can now write:

  @media not (-moz-os-version: ...) {
(Assignee)

Comment 1

3 months ago
Hey Dão, looking to make a first contribution, and this bug seems straightforward. I have Firefox built, and will begin working on this.
(Reporter)

Comment 2

3 months ago
Okay!
Assignee: nobody → andrewc.goupil
(Assignee)

Comment 3

3 months ago
I've completed the css changes, and everything build and runs successfully. Is there any other recommended testing procedures you suggest before submitting the patch ?
(Reporter)

Comment 4

2 months ago
(In reply to andrewc.goupil from comment #3)
> I've completed the css changes, and everything build and runs successfully.
> Is there any other recommended testing procedures you suggest before
> submitting the patch ?

We have a way to get screenshots without and with a patch and compare them automatically, but this change seems simple enough that we don't need to do that here.
(Reporter)

Updated

2 months ago
Priority: -- → P3
(Assignee)

Comment 5

2 months ago
Created attachment 9029821 [details]
Bug 1511850 - Simplify @media not all and (-moz-os-version: ...) queries
Attachment #9029821 - Attachment description: Update Media Queries → Bug 1511850 - Simplify @media not all and (-moz-os-version: ...) queries

Comment 6

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d42abd4f7941
Simplify @media not all and (-moz-os-version: ...) queries. r=dao
(Reporter)

Comment 7

2 months ago
I couldn't land this patch from phabricator / lando. It gave me this error: "Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error."

Here's the link to the FAQ: https://wiki.mozilla.org/Phabricator/FAQ#Lando

I've now pushed this manually to inbound with the right author information.
(Assignee)

Comment 8

2 months ago
Awesome, I will take a look at that document, but thanks for pushing it manually for me
Attachment #9029821 - Attachment is obsolete: true
(Reporter)

Updated

2 months ago
Attachment #9029821 - Attachment is obsolete: false

Comment 9

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d42abd4f7941
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.