1511850 - Simplify @media not all and (-moz-os-version: ...) queries

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[Dão Gottwald [:dao]]

These media queries use an old syntax:

https://searchfox.org/mozilla-central/search?q=%40media+not+all+and+(-moz&case=true&regexp=false

With Media Queries Level 4, instead of:

  @media not all and (-moz-os-version: ...) {

we can now write:

  @media not (-moz-os-version: ...) {

Comment 1

[andrewc.goupil]

Hey Dão, looking to make a first contribution, and this bug seems straightforward. I have Firefox built, and will begin working on this.

Comment 2

[Dão Gottwald [:dao]]

Okay!

Comment 3

[andrewc.goupil]

I've completed the css changes, and everything build and runs successfully. Is there any other recommended testing procedures you suggest before submitting the patch ?

Comment 4

[Dão Gottwald [:dao]]

(In reply to andrewc.goupil from comment #3)
> I've completed the css changes, and everything build and runs successfully.
> Is there any other recommended testing procedures you suggest before
> submitting the patch ?

We have a way to get screenshots without and with a patch and compare them automatically, but this change seems simple enough that we don't need to do that here.

Comment 5

[andrewc.goupil]

Attachment: Bug 1511850 - Simplify @media not all and (-moz-os-version: ...) queries

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d42abd4f7941
Simplify @media not all and (-moz-os-version: ...) queries. r=dao

Comment 7

[Dão Gottwald [:dao]]

I couldn't land this patch from phabricator / lando. It gave me this error: "Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error."

Here's the link to the FAQ: https://wiki.mozilla.org/Phabricator/FAQ#Lando

I've now pushed this manually to inbound with the right author information.

Comment 8

[andrewc.goupil]

Awesome, I will take a look at that document, but thanks for pushing it manually for me

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d42abd4f7941