Closed Bug 1511850 Opened 2 years ago Closed 2 years ago

Simplify @media not all and (-moz-os-version: ...) queries

Categories

(Firefox :: Theme, enhancement, P3)

All
Windows
enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: andrewc.goupil, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

These media queries use an old syntax:

https://searchfox.org/mozilla-central/search?q=%40media+not+all+and+(-moz&case=true&regexp=false

With Media Queries Level 4, instead of:

  @media not all and (-moz-os-version: ...) {

we can now write:

  @media not (-moz-os-version: ...) {
Hey Dão, looking to make a first contribution, and this bug seems straightforward. I have Firefox built, and will begin working on this.
Okay!
Assignee: nobody → andrewc.goupil
I've completed the css changes, and everything build and runs successfully. Is there any other recommended testing procedures you suggest before submitting the patch ?
(In reply to andrewc.goupil from comment #3)
> I've completed the css changes, and everything build and runs successfully.
> Is there any other recommended testing procedures you suggest before
> submitting the patch ?

We have a way to get screenshots without and with a patch and compare them automatically, but this change seems simple enough that we don't need to do that here.
Priority: -- → P3
Attachment #9029821 - Attachment description: Update Media Queries → Bug 1511850 - Simplify @media not all and (-moz-os-version: ...) queries
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d42abd4f7941
Simplify @media not all and (-moz-os-version: ...) queries. r=dao
I couldn't land this patch from phabricator / lando. It gave me this error: "Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error."

Here's the link to the FAQ: https://wiki.mozilla.org/Phabricator/FAQ#Lando

I've now pushed this manually to inbound with the right author information.
Awesome, I will take a look at that document, but thanks for pushing it manually for me
Attachment #9029821 - Attachment is obsolete: true
Attachment #9029821 - Attachment is obsolete: false
https://hg.mozilla.org/mozilla-central/rev/d42abd4f7941
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.