1511946 - Switch to tab icon and text doesn`t appear on Top Sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Activity Stream, defect, P2)

Description

[miralobontiu]

Attachment: 2018_12_04_11_02_23_Trim.mp4

Devices:
 - OnePlus 5T (Android 8.1.0);
 - Xiaomi MiPad 2 (Android 5.0.1);
 - HTC Desire 820 (Android 6.0.1);

Builds:
 - Nightly 65.0a1 (2018-12-03);
 - Beta 64.0b15;
 - Release 63.0.2.

Steps to reproduce:
 1. Open a page on Firefox.
 2. Open another tab and observe on Top Sites, Bookmarks and History panels, the page opened at Step 1.

Expected result:
 "Switch to tab" icon and text should appear on all panels (Top Sites, Bookmarks, History).

Actual result:
 "Switch to tab" icon and text appear only on Bookmarks and History. On Top Sites, only the "Visited" text appears, or "Bookmarked" icon and text if the page was bookmarked.

Notes:
 Switch to tab works without any issues, in all panels.
 Please see attached video.

Comment 1

[Chris Peterson [:cpeterson]]

[arm64:m2] because this bug should block ARM64 Fennec from riding to Beta but doesn't need to block from landing in Nightly.

Comment 2

[Chris Peterson [:cpeterson]]

[arm64:m3] because this bug should block ARM64 Fennec from riding to Beta.

Comment 3

[Chris Peterson [:cpeterson]]

Mirabela says this bug affects both 32-bit ARM and ARM64.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

From what I understand this wasn't intended for the "Recommended by Pocket" feature in the first place.
Ticket for the feature - bug 1380808 where only 3 attributes are possible for a Pocket story: "Trending" / "Visited" / "Bookmarked"
They were also not included when Sebastian updated the general UI for that list rows - bug 1306609.

That being said, I also think that having such a visible hint is useful to the user, moreso because tapping a link will actually take the user to the tab where that page is already opened.

Also, beside this hint (the action exists, there's just no hint to the user) not appearing for "Recommended by Pocket" - feature for which it may have been overlooked, it also doesn't appear for the "Highlights" list items, although this feature predates "Recommended by Pocket".
In this case also, because the action is already there I think it would add to the general UX to also inform the user about the possibility to "Switch to tab" if the page is already opened.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1511946 - Hint about "Switch to tab" option for AwesomeScreen's stream items; r?JanH

The behaviour of switching to an already opened tab for an item in the stream
list was already in place, this patch just modifies the item's layout by
adding a text hint about this possibility - "Switch to tab", dynamically,
depending on if a tab is already opened or not in the current session.

Each stream item will use the same implementation of an OnTabsChangedListener
to inform upstream when the list needs to be updated to account for tab changes
for any of the stream items URLs.

Resorted to use notifyDataSetChanged to re-bind all stream items again in such
situations because the item row will need to have it's height updated after the
"Switch to tab" text is added or removed and the same item can be part of both
the "Recommended by Pocket" and the "Highlights" sections.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ca888f57365
Hint about "Switch to tab" option for AwesomeScreen's stream items; r=JanH

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8ca888f57365

Comment 8

[Stefan Deiac]

Verified as fixed on the latest version of Nightly (67.0a1 2019-02-19) using Nexus 5 (Android 6.0.1).