1512161 - Use Windows & Mac system API for geolocation

Status: VERIFIED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

The title says all

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1512161 - Use Windows & Mac system API for geolocation r?jdm

Comment 2

[Chris Peterson [:cpeterson]]

We also need to confirm that the fallback from the OS location provider to GLS works correctly and is not too long of a delay.

I will be talking with the Data Science team about running an A/B experiment to compare the quality of the OS location providers' and GLS's results.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de1ea2f0c0f
Use Windows & Mac system API for geolocation r=jdm

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6de1ea2f0c0f

Comment 5

[Andrei Vaida [:avaida]]

QA is planning to test this change using the regular Geolocation test suite. Would that suffice or is there something in particular that should be looked at?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Should be good.
Please try with different OS and versions :)
Thanks!

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Emil, has it been verified yet? Thanks

Comment 8

[Andrei Vaida [:avaida]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)

Emil, has it been verified yet? Thanks

Sorry for not updating things here sooner. Yes, Geolocation has been covered as part of the 65.0b7 sign off - Smoke and Regression Testing revealed no issues following this change.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No worries Andrei. thanks!

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9029595 [details]
Bug 1512161 - Use Windows & Mac system API for geolocation r?jdm

ESR Uplift Approval Request

If this is not a sec:{high,crit} bug, please state case for ESR consideration

Not a security issue. We want to limit the traffic on the key by leveraging the system API on Windows & Mac

User impact if declined

Should be transparent for the user, this is for Mozilla

Fix Landed on Version

65

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

We shipped 65 with this change + we pushed an experiment changing that

String or UUID changes made by this patch

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9029595 [details]
Bug 1512161 - Use Windows & Mac system API for geolocation r?jdm

Other than the one issue with the Windows key which we've already remedied, I'm not aware of any negative fallout from the recent Geolocation changes shipped in Fx65 and enabled for ESR60 via experiment. Let's go ahead and land this for 60.6.0 so that we're consistent across all releases and able to reduce our usage of the Google APIs.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/739ae6f8840c

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Andrei, it would be great if this could be verified
Thanks
Note that it isnt always enabled by default on windows

Comment 14

[Gabi Cheta [:Gabi] Desktop QA]

Verified geolocation on the latest 60.6esr build from taskcluster, no issues were found.

For 65 RC the geolocation tests were covered during the 65.0.2-build1 validation, no issues were encountered.