151217 - buglist references the wrong priority field

Status: VERIFIED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Malcolm Scott]

buglist.cgi (as downloaded from CVS today) contains a reference to the column
"priority" rather than "bugs.priority". This causes some problems on the bug
list page, e.g. an error if you try to edit multiple bugs.

This can be fixed by changing line 1340 of buglist.cgi from:

$order = "map_assigned_to.login_name, bugs.bug_status, priority, bugs.bug_id";

to:

$order = "map_assigned_to.login_name, bugs.bug_status, bugs.priority, bugs.bug_id";

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Patch as suggested. This can't possibly hurt, and makes the reference match the
one a few lines further down. I'd say this was an obvious fix.

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 87425 [details] [diff] [review]
Patch v.1

r=bbaetz x2

2.14 had this too

Comment 3

[Jouni Heikniemi]

Should this be in the branch as well? Did this regress from an earlier version?
If so, mark 2.16 on checkin, I'll set 2.18 for now.

Comment 4

[Bradley Baetz (:bbaetz)]

My 'it happens in 2.14.2' comment was a subtle hint that it happened in 2.14,
and doesn't break anything AFAIK, so 2.18 it is.

Comment 5

[Jouni Heikniemi]

And my "earlier version" was a subtle hint that this might've regressed from
something even earlier :-) I'm fine with 2.18.

Comment 6

[Malcolm Scott]

It does break things. E.g. for me (CVS 2.17 downloaded 2002-06-12), 'edit 
multiple bugs simultaneously' didn't work (returned an error relating to this). 
I had to apply this fix before I could get that feature to work.

Comment 7

[Bradley Baetz (:bbaetz)]

Ah, ok, I see now. The ORDER sanity checking fails, because theres no . in the name.

->2.16, -> patch owner

We broke 2.14.2, too! Bleh. I'll patch that when I patch the other regression

Comment 8

[Matthew Tuck [:CodeMachine]]

What does not have . in the name?  Dave said he checked every column.

Comment 9

[Malcolm Scott]

The column "priority" has no . in its name; it should be "bugs.priority". (i.e.
the point of this bug :-) )

Comment 10

[Bradley Baetz (:bbaetz)]

mattyt: the preset query for Assign. It works intially, but then its set in the
cookie/QUERY_STRING, and fails in the future.

Comment 11

[Gervase Markham [:gerv]]

Checked in on trunk and 2.16 branch. What are we doing about 2.14.2? Do I need
to pull one of those and check in there too? Should this bug be closed?

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.169.2.10; previous revision: 1.169.2.9
done

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.178; previous revision: 1.177
done

Gerv

Comment 12

[Bradley Baetz (:bbaetz)]

Theres a separate bug fixing this issue + the trim issue for 2.14.

You can mark this bug FIXED.

Comment 13

[Dave Miller [:justdave]]

per comments.

Comment 14

[Dave Miller [:justdave]]

and just for the record, I wasn't the one who checked all the columns.  I don't
know who did, this all happened during one of the weeks when I wasn't around much.

Comment 15

[Matthew Tuck [:CodeMachine]]

Jun 06 13:37:59 <justdave>	I enabled every column in the change columns thing
and tried sorting on each of them

Comment 16

[Malcolm Scott]

Verifying fixed.