Update Preferences Spotlight colour, border and fading

VERIFIED FIXED in Firefox 65

Status

()

defect
P1
normal
VERIFIED FIXED
8 months ago
4 months ago

People

(Reporter: ewright, Assigned: ewright)

Tracking

65 Branch
Firefox 66
Points:
---

Firefox Tracking Flags

(firefox65 verified, firefox66 verified)

Details

Attachments

(2 attachments)

I've attached a screenshot of the new proposed spotlight visuals. 

the dotted outline is photon blue-60.
the background is photon blue-40 at 1% alpha.
it fades after 2 seconds with a 500ms animation.
Change the coloring of the spotlight, and add a fadeout
Assignee: nobody → ewright
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Update Preferences Spotlight → Update Preferences Spotlight colour, border and fading
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59a0f0a43a12
Update preferences spotlight color. r=jaws
https://hg.mozilla.org/mozilla-central/rev/59a0f0a43a12
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Is this something we wanted to nominate for Beta uplift?
Flags: needinfo?(ewright)
Comment on attachment 9029626 [details]
Bug 1512187 - Update preferences spotlight color.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: The previous aqua highlight clashes with the new privacy UI landing in 65. This new highlight looks good with the new UI and the old UI.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): straightforward css visual change

String changes made/needed: none
Flags: needinfo?(ewright)
Attachment #9029626 - Flags: approval-mozilla-beta?
Comment on attachment 9029626 [details]
Bug 1512187 - Update preferences spotlight color.

[Triage Comment]
Visual tweak for the preferences spotlight. Approved for 65.0b6.
Attachment #9029626 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have reproduced this bug on nightly according to (2018-12-05)

Fixing bug is verified on Latest Beta and also Latest Nightly
Firefox beta:
Build ID :20190307095232
User Agent : Mozilla/5.0 (Windows NT 6.1; rv:66.0) Gecko/20100101 Firefox/66.0
Nightly :
Build ID :20190309215319
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:67.0) Gecko/20100101 Firefox/67.0

This issue has solved

Tested OS--Windows 7,32bit

QA Whiteboard: [testday-20190308]

Thank you, Saheda Reza!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.