1512187 - Update Preferences Spotlight colour, border and fading

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Erica Wright [:ewright]]

Attachment: Screen Shot 2018-11-30 at 3.00.44 PM.png

I've attached a screenshot of the new proposed spotlight visuals. 

the dotted outline is photon blue-60.
the background is photon blue-40 at 1% alpha.
it fades after 2 seconds with a 500ms animation.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1512187 - Update preferences spotlight color.

Change the coloring of the spotlight, and add a fadeout

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a0f0a43a12
Update preferences spotlight color. r=jaws

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/59a0f0a43a12

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we wanted to nominate for Beta uplift?

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9029626 [details]
Bug 1512187 - Update preferences spotlight color.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: The previous aqua highlight clashes with the new privacy UI landing in 65. This new highlight looks good with the new UI and the old UI.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): straightforward css visual change

String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9029626 [details]
Bug 1512187 - Update preferences spotlight color.

[Triage Comment]
Visual tweak for the preferences spotlight. Approved for 65.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2fe74b55dfcc

Comment 8

[Saheda Reza [:Antora]]

I have reproduced this bug on nightly according to (2018-12-05)

Fixing bug is verified on Latest Beta and also Latest Nightly
Firefox beta:
Build ID :20190307095232
User Agent : Mozilla/5.0 (Windows NT 6.1; rv:66.0) Gecko/20100101 Firefox/66.0
Nightly :
Build ID :20190309215319
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:67.0) Gecko/20100101 Firefox/67.0

This issue has solved

Tested OS--Windows 7,32bit

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you, Saheda Reza!