1512281 - Add a pref to turn off RTCP in WebRTC to prevent regressions in which the local stats are used for the remote stats (again)

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

After merges of the upstream WebRTC.org library into the Firefox codebase, it is not unusual for RTCP stats to break. One of the common failure modalities is using local RTCP stats for the remote stats. I propose adding a pref that quashes RTCP traffic which can be used in tests to to ensure that RTCP stats are not received when disabled.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bee01ffa750a2ef05ee6ebdd90e24e11079c91e6

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e59441effe1c66064d4034cf52067cffaa21403

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c02152761f6c51225208a3cdea18f58246c3142

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab57ee9bcb90de73f6a4a53b506b71ade867faf3

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1512281 - Adding pref to turn off WebRTC RTCP reception for tests

Adds a pref to turn off WebRTC RTCP reception for tests, and an associated mochitest.
Once fixed the RTCP regression should cause the mochitest to unexpectedly pass

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6da80e0c51bff079d65a6aef3aaaa571cb08f076

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c68239b7eb663825a8944da7d9859c2162d7bff8

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b7c5238545614f0e1c9787f664097c305feb1b7

Comment 9

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a110e1a2aa32551de5f0119bbe5397c31726bdf2

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b19cc55527
Adding pref to turn off WebRTC RTCP reception for tests r=dminor

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e8b19cc55527