Closed
Bug 1512281
Opened 5 years ago
Closed 5 years ago
Add a pref to turn off RTCP in WebRTC to prevent regressions in which the local stats are used for the remote stats (again)
Categories
(Core :: WebRTC, enhancement, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: ng, Assigned: ng)
Details
Attachments
(1 file)
After merges of the upstream WebRTC.org library into the Firefox codebase, it is not unusual for RTCP stats to break. One of the common failure modalities is using local RTCP stats for the remote stats. I propose adding a pref that quashes RTCP traffic which can be used in tests to to ensure that RTCP stats are not received when disabled.
Assignee | ||
Updated•5 years ago
|
Rank: 19
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bee01ffa750a2ef05ee6ebdd90e24e11079c91e6
Assignee | ||
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e59441effe1c66064d4034cf52067cffaa21403
Assignee | ||
Comment 3•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c02152761f6c51225208a3cdea18f58246c3142
Assignee | ||
Comment 4•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab57ee9bcb90de73f6a4a53b506b71ade867faf3
Assignee | ||
Comment 5•5 years ago
|
||
Adds a pref to turn off WebRTC RTCP reception for tests, and an associated mochitest. Once fixed the RTCP regression should cause the mochitest to unexpectedly pass
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6da80e0c51bff079d65a6aef3aaaa571cb08f076
Assignee | ||
Comment 7•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c68239b7eb663825a8944da7d9859c2162d7bff8
Assignee | ||
Comment 8•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b7c5238545614f0e1c9787f664097c305feb1b7
Comment 9•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
Flags: needinfo?(na-g)
Assignee | ||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/e8b19cc55527 Adding pref to turn off WebRTC RTCP reception for tests r=dminor
Comment 12•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•2 months ago
|
Flags: needinfo?(na-g)
You need to log in
before you can comment on or make changes to this bug.
Description
•