Closed Bug 1512281 Opened 1 year ago Closed 1 year ago

Add a pref to turn off RTCP in WebRTC to prevent regressions in which the local stats are used for the remote stats (again)

Categories

(Core :: WebRTC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: ng, Assigned: ng, NeedInfo)

Details

Attachments

(1 file)

After merges of the upstream WebRTC.org library into the Firefox codebase, it is not unusual for RTCP stats to break. One of the common failure modalities is using local RTCP stats for the remote stats. I propose adding a pref that quashes RTCP traffic which can be used in tests to to ensure that RTCP stats are not received when disabled.
Rank: 19
Adds a pref to turn off WebRTC RTCP reception for tests, and an associated mochitest.
Once fixed the RTCP regression should cause the mochitest to unexpectedly pass

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?

Flags: needinfo?(na-g)
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/e8b19cc55527
Adding pref to turn off WebRTC RTCP reception for tests r=dminor
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.