1512332 - Update focus ring acording to photon specs

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P2)

Description

[Matthias :Kammueller]

Everything (menulists etc) should have the blue focus shadow.

Comment 1

[Matthias :Kammueller]

Attachment: Bug 1512332 - Photonized focusring for menulist etc. r=dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f306a3db8b35
Photonized focusring for menulist etc. r=dao

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f306a3db8b35 (Bug 1512332) for bc failures on chrome://global/skin/in-content/common.css.

Backout: https://hg.mozilla.org/integration/autoland/rev/25f55c5ebcfb1263b910551ac0f9599345c1b6f2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=f306a3db8b35c5821cbfdebd85f83b7da91822c8&selectedJob=217261196

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217261196&repo=autoland&lineNumber=1909

Comment 4

[Matthias :Kammueller]

I'm sorry, but I have no idea how to fix this error and why it occurs =/
@dao, can you help me?

Comment 5

[Dão Gottwald [:dao]]

The error message is:

Expected identifier for pseudo-class parameter but found ‘:’. Ruleset ignored due to bad selector.

The problem appears to be the chained pseudo-element selectors that CSS doesn't seem to allow:

html|input[type="color"]::-moz-number-spin-up::-moz-focus-inner,
html|input[type="number"]::-moz-number-spin-down::-moz-focus-inner

(There's also another typo in there... "color" should be "number".)

Comment 6

[Matthias :Kammueller]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d3e58603f15a4960a508eb0631aed5663d02bdf

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b02de5a5396b
Photonized focusring for menulist etc. r=dao

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b02de5a5396b