1512353 - "nativeTab is null" when using browser.tabs.move to move regular tab to incognito window

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[Rob Hoelz]

Attachment: background.js

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

  * Set up test WebExtension to move tabs in a regular (non-incognito) window to an incognito one (manifest and background JS attached) - run via web-ext
  * Open the browser console 
  * Open an incognito window
  * Right click on the tab in the non-incognito window (which we'll call tab A)
  * Under the "Incognito Move Window Test" menu, click the "Move Tab to Incognito Window" action


Actual results:

  * The return value from browser.tabs.move returns a non-empty array, implying that tab A was successfully moved
  * A new, empty tab (which we'll call tab B) is added to the incognito window, alongside the tab that was there when the window was created (which we'll call tab C)
  * Repeating the "Incognito Move Window Test" action on tab A moves B to the right-most position in the incognito window, implying that tab B is somehow bound to the menu associated with tab A
  * If you close tab B and activate the "Get Tab Data" action on tab A, you'll see console output referring to information associated with tab B, and browser.tabs.get will be unable to resolve the tab ID supplied to the menu onClick event listener.


Expected results:

I would expect browser.tabs.move to ignore moving tabs between regular and non-incognito windows entirely, and for the return value of browser.tabs.move to omit any such tabs.

Comment 1

[Rob Hoelz]

Attachment: manifest.json

Comment 2

[David Durst [:ddurst]]

NI Shane to see if this is covered in the upcoming private browsing work

Comment 3

[Shane Caraveo (:mixedpuppy)]

maybe addressed in bug 1345474, I'll look later.

Comment 4

[Shane Caraveo (:mixedpuppy)]

As of 67, I get an error "nativeTab is null"[1], however since that changes when we turn on the incognito support, I'm going to close this. You cannot move a non-private tab to a private window.

[1] https://searchfox.org/mozilla-central/rev/6e3cc153566f5f288ae768a2172385b8436d61dd/browser/components/extensions/parent/ext-tabs.js#918

Comment 5

[Shane Caraveo (:mixedpuppy)]

On second thought, the error in comment 4 does need to be addressed.

I suspect the incognito work changed the prior behavior, but we actually want something better than an internal error.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1512353 skip moving windows between pb and non-pb windows

Comment 7

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5061b881eec4cd93ac335b272c3ba27aba9901e3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e42ba4e47d65
skip moving windows between pb and non-pb windows r=zombie

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e42ba4e47d65