Closed Bug 1512386 Opened 4 years ago Closed 4 years ago

Case-sensitive attribute selectors (from Selectors level 4)

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: e7358d9c, Assigned: bzbarsky)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 1 obsolete file)

Bug 1512386. Add support for 's' flag on attribute selectors. r=emilio
47 bytes, text/x-phabricator-request
Details | Review
MDN: Browser compatibility table update
52 bytes, text/x-github-pull-request
Details | Review 
      No description provided.

    
    

    
  
Since this was entirely unclear from the original report: this is about supporting [foo="bar" s] syntax that just got added to the Selectors 4 draft 4 days ago.

    
    

    
  
Does this spec come with tests, by the way?

    
    

    
  
Writing tests caught obvious bug in the naive implementation, of course...

    
    

    
  


  
We could keep using ParsedCaseSensitivity::CaseSensitive as a temporary stand-in
for "case-sensitive or maybe not depending on what HTML says" until we check the
attribute list, but it seems better to make that explicit.

    
    

    
  
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfd73976f27e
Add support for 's' flag on attribute selectors.  r=emilio

    
    

    
  
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14451 for changes under testing/web-platform/tests

    
    

    
  
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/bfd73976f27e
Status: NEW → RESOLVED
Closed: 4 years ago

          status-firefox66:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → bzbarsky

    
    

    
  
Don't forget to send an intent email for this :)
Flags: needinfo?(bzbarsky)

    
    

    
  
Good catch, done.
Flags: needinfo?(bzbarsky)

    
    

    
  


  
This PR updates the browser compatibility data to document support for Firefox 66.

        Attachment #9029777 -
        Attachment is obsolete: true

    
  
Depends on: 1514029

          You need to log in
          before you can comment on or make changes to this bug.