Closed Bug 1512416 Opened 6 years ago Closed 5 years ago

[Wayland] OpenGL/HiDPI does not react well to scale changes

Categories

(Core :: Widget: Gtk, enhancement, P2)

Product:
Core
Component:
Widget: Gtk
Platform:
Unspecified
Linux
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1512416 - [Wayland/OpenGL] Resize wl_elg_window when widget scale changes, r=jhorak"
47 bytes, text/x-phabricator-request
Details | Review 
This is a folow up from Bug #1511951 comment #4

> My two cents on your patch. In addition to setup scale factor on
> initialization, we also need to react to changing of scale factor (change
> surface scale factor or maybe something else). It can happen if a user
> change it directly in DE settings or for example the window moved from
> LowDPI screen to HiDPI screen (as greg mentioned). To subscribe scale factor
> changing, we can connect to signal "notify::scale-factor" of MozContainer. I
> hope that helps.
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61de4550c887
[Wayland/OpenGL] Resize wl_elg_window when widget scale changes, r=jhorak"
Keywords: checkin-needed
Backed out changeset 61de4550c887 (Bug 1512416) for bustages in builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp:230:15

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=adcf05cc20255510741620dabdbf442a1d3ed0b1&selectedJob=217672218

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217672218&repo=autoland&lineNumber=25930

[task 2018-12-18T13:45:46.978Z] 13:45:46     INFO -                               ~~~~~~~~~~~~~~~^~~~~~~~~
[task 2018-12-18T13:45:46.978Z] 13:45:46     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/mathml'
[task 2018-12-18T13:45:46.982Z] 13:45:46     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/tools/layout-debug/src'
[task 2018-12-18T13:45:46.982Z] 13:45:46     INFO -  mkdir -p '.deps/'
[task 2018-12-18T13:45:46.982Z] 13:45:46     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/tools/layout-debug/src'
[task 2018-12-18T13:45:46.983Z] 13:45:46     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/tools/layout-debug/src'
[task 2018-12-18T13:45:46.983Z] 13:45:46     INFO -  layout/tools/layout-debug/src
[task 2018-12-18T13:45:46.984Z] 13:45:46     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/tools/layout-debug/src'
[task 2018-12-18T13:45:46.984Z] 13:45:46     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/tools/layout-debug/src'
[task 2018-12-18T13:45:46.985Z] 13:45:46     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/tools/layout-debug/src'
[task 2018-12-18T13:45:47.006Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/ipc'
[task 2018-12-18T13:45:47.008Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_layout_ipc0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/layout/ipc -I/builds/worker/workspace/build/src/obj-firefox/layout/ipc -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_layout_ipc0.o.pp   /builds/worker/workspace/build/src/obj-firefox/layout/ipc/Unified_cpp_layout_ipc0.cpp
[task 2018-12-18T13:45:47.008Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/ipc'
[task 2018-12-18T13:45:47.028Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base'
[task 2018-12-18T13:45:47.029Z] 13:45:47     INFO -  mkdir -p '.deps/'
[task 2018-12-18T13:45:47.030Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base'
[task 2018-12-18T13:45:47.030Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base'
[task 2018-12-18T13:45:47.031Z] 13:45:47     INFO -  docshell/base
[task 2018-12-18T13:45:47.031Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base'
[task 2018-12-18T13:45:47.031Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base'
[task 2018-12-18T13:45:47.032Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base'
[task 2018-12-18T13:45:47.119Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/xul'
[task 2018-12-18T13:45:47.120Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_layout_xul1.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/obj-firefox/layout/xul -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/painting -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_layout_xul1.o.pp   /builds/worker/workspace/build/src/obj-firefox/layout/xul/Unified_cpp_layout_xul1.cpp
[task 2018-12-18T13:45:47.120Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/xul'
[task 2018-12-18T13:45:47.124Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:47.124Z] 13:45:47     INFO -  mkdir -p '.deps/'
[task 2018-12-18T13:45:47.125Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:47.127Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:47.127Z] 13:45:47     INFO -  docshell/base/timeline
[task 2018-12-18T13:45:47.128Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:47.128Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:47.128Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:47.168Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/widget/gtk'
[task 2018-12-18T13:45:47.172Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_widget_gtk1.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DCAIRO_GFX '-DMOZ_APP_NAME="firefox"' -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/widget/gtk -I/builds/worker/workspace/build/src/obj-firefox/widget/gtk -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/other-licenses/atk-1.0 -I/builds/worker/workspace/build/src/widget -I/builds/worker/workspace/build/src/widget/headless -I/builds/worker/workspace/build/src/widget/x11 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_widget_gtk1.o.pp   /builds/worker/workspace/build/src/obj-firefox/widget/gtk/Unified_cpp_widget_gtk1.cpp
[task 2018-12-18T13:45:47.173Z] 13:45:47     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/EndianUtils.h:69:0,
[task 2018-12-18T13:45:47.173Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/gfx/Types.h:10,
[task 2018-12-18T13:45:47.174Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/gfx/2D.h:10,
[task 2018-12-18T13:45:47.174Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/widget/WindowSurface.h:10,
[task 2018-12-18T13:45:47.174Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/widget/gtk/WindowSurfaceX11.h:12,
[task 2018-12-18T13:45:47.174Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/widget/gtk/WindowSurfaceXRender.h:12,
[task 2018-12-18T13:45:47.174Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/widget/gtk/WindowSurfaceXRender.cpp:7,
[task 2018-12-18T13:45:47.176Z] 13:45:47     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/widget/gtk/Unified_cpp_widget_gtk1.cpp:2:
[task 2018-12-18T13:45:47.177Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp: In function 'void moz_container_scale_changed(MozContainer*, GtkAllocation*)':
[task 2018-12-18T13:45:47.177Z] 13:45:47    ERROR -  /builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp:230:15: error: statement-expressions are not allowed outside functions nor in template-argument lists
[task 2018-12-18T13:45:47.177Z] 13:45:47     INFO -     MOZ_ASSERT(!GDK_IS_X11_DISPLAY(gdk_display_get_default()),
[task 2018-12-18T13:45:47.177Z] 13:45:47     INFO -                 ^
[task 2018-12-18T13:45:47.177Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:436:66: note: in definition of macro 'MOZ_VALIDATE_ASSERT_CONDITION_TYPE'
[task 2018-12-18T13:45:47.177Z] 13:45:47     INFO -     static_assert(mozilla::detail::AssertionConditionType<decltype(x)>::isValid, \
[task 2018-12-18T13:45:47.177Z] 13:45:47     INFO -                                                                    ^
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:473:39: note: in expansion of macro 'MOZ_ASSERT_HELPER2'
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -   #define MOZ_RELEASE_ASSERT_GLUE(a, b) a b
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -                                         ^
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:475:3: note: in expansion of macro 'MOZ_RELEASE_ASSERT_GLUE'
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -     MOZ_RELEASE_ASSERT_GLUE(                                            \
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -     ^~~~~~~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:480:25: note: in expansion of macro 'MOZ_RELEASE_ASSERT'
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -   #define MOZ_ASSERT(...) MOZ_RELEASE_ASSERT(__VA_ARGS__)
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -                           ^~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp:230:3: note: in expansion of macro 'MOZ_ASSERT'
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -     MOZ_ASSERT(!GDK_IS_X11_DISPLAY(gdk_display_get_default()),
[task 2018-12-18T13:45:47.180Z] 13:45:47     INFO -     ^
[task 2018-12-18T13:45:47.181Z] 13:45:47    ERROR -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:436:68: error: template argument 1 is invalid
[task 2018-12-18T13:45:47.181Z] 13:45:47     INFO -     static_assert(mozilla::detail::AssertionConditionType<decltype(x)>::isValid, \
[task 2018-12-18T13:45:47.181Z] 13:45:47     INFO -                                                                      ^
[task 2018-12-18T13:45:47.181Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:464:5: note: in expansion of macro 'MOZ_VALIDATE_ASSERT_CONDITION_TYPE'
[task 2018-12-18T13:45:47.181Z] 13:45:47     INFO -       MOZ_VALIDATE_ASSERT_CONDITION_TYPE(expr);                            \
[task 2018-12-18T13:45:47.183Z] 13:45:47     INFO -       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.183Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:473:39: note: in expansion of macro 'MOZ_ASSERT_HELPER2'
[task 2018-12-18T13:45:47.184Z] 13:45:47     INFO -   #define MOZ_RELEASE_ASSERT_GLUE(a, b) a b
[task 2018-12-18T13:45:47.184Z] 13:45:47     INFO -                                         ^
[task 2018-12-18T13:45:47.184Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:475:3: note: in expansion of macro 'MOZ_RELEASE_ASSERT_GLUE'
[task 2018-12-18T13:45:47.185Z] 13:45:47     INFO -     MOZ_RELEASE_ASSERT_GLUE(                                            \
[task 2018-12-18T13:45:47.185Z] 13:45:47     INFO -     ^~~~~~~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.185Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MacroArgs.h:16:26: note: in expansion of macro 'MOZ_CONCAT2'
[task 2018-12-18T13:45:47.186Z] 13:45:47     INFO -   #define MOZ_CONCAT(x, y) MOZ_CONCAT2(x, y)
[task 2018-12-18T13:45:47.186Z] 13:45:47     INFO -                            ^~~~~~~~~~~
[task 2018-12-18T13:45:47.186Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MacroArgs.h:70:51: note: in expansion of macro 'MOZ_CONCAT'
[task 2018-12-18T13:45:47.187Z] 13:45:47     INFO -   #define MOZ_PASTE_PREFIX_AND_ARG_COUNT_GLUE(a, b) a b
[task 2018-12-18T13:45:47.187Z] 13:45:47     INFO -                                                     ^
[task 2018-12-18T13:45:47.187Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MacroArgs.h:72:3: note: in expansion of macro 'MOZ_PASTE_PREFIX_AND_ARG_COUNT_GLUE'
[task 2018-12-18T13:45:47.188Z] 13:45:47     INFO -     MOZ_PASTE_PREFIX_AND_ARG_COUNT_GLUE(MOZ_CONCAT,    \
[task 2018-12-18T13:45:47.188Z] 13:45:47     INFO -     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.189Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:476:7: note: in expansion of macro 'MOZ_PASTE_PREFIX_AND_ARG_COUNT'
[task 2018-12-18T13:45:47.190Z] 13:45:47     INFO -         MOZ_PASTE_PREFIX_AND_ARG_COUNT(MOZ_ASSERT_HELPER, __VA_ARGS__), \
[task 2018-12-18T13:45:47.190Z] 13:45:47     INFO -         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.191Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:480:25: note: in expansion of macro 'MOZ_RELEASE_ASSERT'
[task 2018-12-18T13:45:47.192Z] 13:45:47     INFO -   #define MOZ_ASSERT(...) MOZ_RELEASE_ASSERT(__VA_ARGS__)
[task 2018-12-18T13:45:47.192Z] 13:45:47     INFO -                           ^~~~~~~~~~~~~~~~~~
[task 2018-12-18T13:45:47.192Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp:230:3: note: in expansion of macro 'MOZ_ASSERT'
[task 2018-12-18T13:45:47.192Z] 13:45:47     INFO -     MOZ_ASSERT(!GDK_IS_X11_DISPLAY(gdk_display_get_default()),
[task 2018-12-18T13:45:47.192Z] 13:45:47     INFO -     ^
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1131: recipe for target 'Unified_cpp_widget_gtk1.o' failed
[task 2018-12-18T13:45:47.193Z] 13:45:47    ERROR -  make[4]: *** [Unified_cpp_widget_gtk1.o] Error 1
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/widget/gtk'
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/shistory'
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  mkdir -p '.deps/'
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/shistory'
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/shistory'
[task 2018-12-18T13:45:47.193Z] 13:45:47     INFO -  docshell/shistory
[task 2018-12-18T13:45:47.194Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/shistory'
[task 2018-12-18T13:45:47.194Z] 13:45:47     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/shistory'
[task 2018-12-18T13:45:47.194Z] 13:45:47     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/shistory'
[task 2018-12-18T13:45:48.301Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:48.301Z] 13:45:48     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_base_timeline0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/docshell/base/timeline -I/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_base_timeline0.o.pp   /builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline/Unified_cpp_base_timeline0.cpp
[task 2018-12-18T13:45:48.301Z] 13:45:48     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/base/timeline'
[task 2018-12-18T13:45:48.304Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/build'
[task 2018-12-18T13:45:48.304Z] 13:45:48     INFO -  mkdir -p '.deps/'
[task 2018-12-18T13:45:48.306Z] 13:45:48     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/build'
[task 2018-12-18T13:45:48.306Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/build'
[task 2018-12-18T13:45:48.306Z] 13:45:48     INFO -  docshell/build
[task 2018-12-18T13:45:48.307Z] 13:45:48     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/build'
[task 2018-12-18T13:45:48.307Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/docshell/build'
[task 2018-12-18T13:45:48.307Z] 13:45:48     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/docshell/build'
[task 2018-12-18T13:45:48.395Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/inspector'
[task 2018-12-18T13:45:48.396Z] 13:45:48     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_layout_inspector0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/layout/inspector -I/builds/worker/workspace/build/src/obj-firefox/layout/inspector -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/xbl -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_layout_inspector0.o.pp   /builds/worker/workspace/build/src/obj-firefox/layout/inspector/Unified_cpp_layout_inspector0.cpp
[task 2018-12-18T13:45:48.396Z] 13:45:48     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/inspector'
[task 2018-12-18T13:45:48.404Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpfe/appshell'
[task 2018-12-18T13:45:48.404Z] 13:45:48     INFO -  mkdir -p '.deps/'
[task 2018-12-18T13:45:48.404Z] 13:45:48     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpfe/appshell'
[task 2018-12-18T13:45:48.405Z] 13:45:48     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpfe/appshell'
[task 2018-12-18T13:45:48.405Z] 13:45:48     INFO -  xpfe/appshell
Flags: needinfo?(stransky)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9599f1a2faa
Backed out changeset 61de4550c887 for bustages in builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp:230:15
Flags: needinfo?(stransky)
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be2cd52df099
[Wayland/OpenGL] Resize wl_elg_window when widget scale changes, r=jhorak"
Keywords: checkin-needed
I wonder why the patches fails when the try looks fine and builds.
Flags: needinfo?(stransky)
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dd9ac3dae16
[Wayland/OpenGL] Resize wl_elg_window when widget scale changes, r=jhorak"
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8dd9ac3dae16
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Is this something which needs uplift consideration or can it ride the trains?
Flags: needinfo?(stransky)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)
> Is this something which needs uplift consideration or can it ride the trains?

It can ride the train as it's for Wayland/OpengGL/HiDPI combination only. Thanks.
Flags: needinfo?(stransky)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: