Closed Bug 1512417 Opened 7 years ago Closed 7 years ago

Pass |this| as second argument to Cu.import calls in Promise-backend.js

Categories

(Core :: XPConnect, enhancement)

Product:
Core
Component:
XPConnect
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Bug 1512417 - Pass |this| as second argument to Cu.import calls in Promise-backend.js to fix an issue with same-compartment realms. r?kmag
47 bytes, text/x-phabricator-request
Details | Review
This fixes an issue with same-compartment realms: the Cu.import native is in a different realm so we switch to that and end up defining things on the wrong global. See bug 1512029 comment 9 and comment 10.
With same-compartment-realms, the Cu.import native is a cross-realm function so we switch to its realm and ended up defining things on the wrong global.
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52d8651b683d Pass |this| as second argument to Cu.import calls in Promise-backend.js to fix an issue with same-compartment realms. r=kmag
https://hg.mozilla.org/mozilla-central/rev/52d8651b683d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: