Closed
Bug 1512417
Opened 6 years ago
Closed 5 years ago
Pass |this| as second argument to Cu.import calls in Promise-backend.js
Categories
(Core :: XPConnect, enhancement)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
This fixes an issue with same-compartment realms: the Cu.import native is in a different realm so we switch to that and end up defining things on the wrong global. See bug 1512029 comment 9 and comment 10.
|
Assignee | |
Comment 1•6 years ago
|
||
With same-compartment-realms, the Cu.import native is a cross-realm function so we switch to its realm and ended up defining things on the wrong global.
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52d8651b683d Pass |this| as second argument to Cu.import calls in Promise-backend.js to fix an issue with same-compartment realms. r=kmag
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52d8651b683d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•