151245 - img src not able to be set in onerror/onclick handler

Status: RESOLVED DUPLICATE of bug 22820

(Core :: DOM: Events, defect)

Description

[Bob Clary [:bc] (inactive)]

I looked but could not find this bug in bugzilla. The following two test cases
work in IE6 and Nav4 but do not work in Mozilla trunk or branch 2002 06 10

This bug is important for a major web site. I need to know what the situation is
with this bug ASAP.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: testcase img onerror

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: testcase a onclick

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: testcase img onmouseover (works)

Note that onmouseover can change the src of an img

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: workaround by replacing img using the dom

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: fixed workaround

Comment 6

[saari (gone)]

joki is gone -> bryner

Comment 7

[Brian Ryner (not reading)]

So, the main problem here is that kicking off a new image load happens via
nsImageFrame's handling of the 'src' attribute change.  In the case where the
image originally failed to load, we've constructed an nsInlineFrame instead of
an nsImageFrame, so there is no handling of the src attribute change.  I think
we need to make a reframe happen in this case.

Comment 8

[Brian Ryner (not reading)]

It's kind of gross, but I came up with a workaround that tells the document that
the image content has been replaced if 'src' is set and we have a frame that's
not an image frame.

Per conversation with dbaron, a better way to fix this would be to move the
image loading code into nsHTMLImageElement and then notify the frame constructor
that it needs to construct a new frame, either via a direct API or by having a
CSS pseudoclass that indicates that the element is replaced (we would unset the
pseudoclass when the 'src' is chanegd, and the style system would know to
construct a new frame).

Comment 9

[Brian Ryner (not reading)]

Attachment: hacky fix

Comment 10

[Brian Ryner (not reading)]

Actually, there's a better discussion of the problem and a possible fix over in
bug 22820.  The failure of the testcases here does not have anything to do with
being in an onerror or onclick handler, it's all because the original image src
was invalid.

*** This bug has been marked as a duplicate of 22820 ***