Closed Bug 1512514 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14403 - [ScrollTimeline] Upstream based currentTime tests to WPT

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14403 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14403
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:
>  [ScrollTimeline] Upstream based currentTime tests to WPT
>  
>  This CL starts to upstream the currentTime tests to WPT. To split this
>  up, we start with just the 'basic' tests - basic functionality,
>  adjusting for time range, and start/end scroll offsets. The writing mode
>  and NaN tests will follow in later patches.
>  
>  There are a few mostly non-behavioral changes to the tests in this CL:
>  
>    * Some comments were edited for clarity.
>    * For tests with more than one assert_equals(), descriptions were
>      added to the asserts. This is to help locate failing assert_equal
>      lines, as jsharness does not print out the line number of a failure.
>    * In a few places we had more than one assert_equals for the same
>      scenario (e.g. multiple cases where scroll was after the
>      startScrollOffset point). These have been deduplicated.
>  
>  Bug: 911254
>  Change-Id: I783fcf7f43cda876defa9c36db9a0e7dff4e82c7
>  Reviewed-on: https://chromium-review.googlesource.com/1366297
>  WPT-Export-Revision: 479c23e2cf5cfff950d7e875e0551fd45393f9d1
Ran 1 tests and 7 subtests
OK     : 1
FAIL   : 7

New tests that have failures or other problems:
/scroll-animations/current-time.html
    currentTime adjusts correctly for the timeRange: FAIL
    currentTime calculates the correct time based on scrolled amount: FAIL
    currentTime handles endScrollOffset correctly: FAIL
    currentTime handles startScrollOffset == endScrollOffset correctly: FAIL
    currentTime handles startScrollOffset > endScrollOffset correctly: FAIL
    currentTime handles startScrollOffset and endScrollOffset together correctly: FAIL
    currentTime handles startScrollOffset correctly: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7472777113
[wpt PR 14403] - [ScrollTimeline] Upstream based currentTime tests to WPT, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc942d811f6
[wpt PR 14403] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8d7472777113
https://hg.mozilla.org/mozilla-central/rev/2fc942d811f6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.