1512597 - SVG fill: currentColor is incorrect if parent is an a:visited element

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[marius]

Attachment: svg-currentcolor.html

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/5.12.0 Chrome/69.0.3497.128 Safari/537.36

Steps to reproduce:

When using an svg element inside a link element with the css property of fill: currentColor, the color is not actually respected if the link has been visited.

For a test case please see the attached file.

Once the link gets clicked, the color should change to follow the color of the link text.


Actual results:

Even if the link is visited the svg fill color is kept to the base color of an <a/> element.


Expected results:

The svg fill color should change if the link has been visited to the color of a:visited css rule.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=82322f1fcb1fc0161f7be2ba41bd62d049d5e4fa&tochange=7d7fe1b01693a2da11a604dc3e54afaab7f344fd

Regressed by:Bug 1467622

@:kamidphish,
Your bunch of patch seems to cause the regression. Can you please look into this?

Comment 2

[u480271]

I'm busy on WebRender, so I've asked :heycam if he has spare cycles to look into the issue for me.

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=165039a97aa6583fa8c35fd6c7c43772a28f6457

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c37403b674f69b682e5a6a51bf9ed33616b1217c

Comment 5

[Cameron McCormack (:heycam)]

Attachment: Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Thanks, heycam!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ced915a7d2d
Resolve currentcolor in fill and stroke against visited-dependent color r=xidorn

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It might be nice to also have a test that unvisited links use the unvisited color.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6ced915a7d2d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 9031777 [details]
Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1467622

User impact if declined: Incorrect styling in certain SVG documents using :visited styles

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Very small change, with tests.

String changes made/needed:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9031777 [details]
Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color

[Triage Comment]
Fixes incorrect styling in certain SVG documents using :visited styles. Approved for 65.0b8.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3911d8355cbb