151262 - XUL fastload sends garbage to CSS parser

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

One of the reasons for the performance regressions with XUL fastload is that
it's sending garbage to the CSS parser -- a bunch of empty strings and class
attributes.  I noticed this a few weeks ago and should have looked into it then
or pointed someone to it.  However, the fix is trivial, and will be attached. 
(nsIContent::GetAttr has multiple success values.)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

I should have said "may be", since I haven't actually measured performance --
it may not be measurable.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 87393 [details] [diff] [review]
patch

sr=[e-mail]

Comment 3

[Chris Waterson]

Comment on attachment 87393 [details] [diff] [review]
patch

r=waterson!

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2002-06-13 15:14 PDT.

comet Txul times:
  before: 471,479,479,475 (mean: 476.00)
  after: 463,469,468 (mean: 466.67)
  t-test p=0.018

comet Ts times:
  before: 1561,1557,1568,1547 (mean: 1558.25)
  after: 1531,1542,1532 (mean: 1535.00)
  t-test p=0.0090

There were other changes that could have mattered, although not between the last
cycle before and first cycle after.

Comment 5

[shrirang khanzode]

help, jrgm, Thx!