1512673 - Use booleans consistently in the IPDL compiler, instead of using 0/1s

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

Some of the IPDL code is really old school Python, predating bools being a real part of the language! We should modernize it. I've got a patch that starts with the fields on |ast.Type|.

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1512673 - convert several fields in the IPDL compiler from integers to bools; r?nika

Comment 2

[Daniel Varga [:dvarga]]

Hello, 
Can you please get a reviewer to accept the current diff?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/985505cc1347
convert several fields in the IPDL compiler from integers to bools; r=nika

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 985505cc1347 (bug 1512673) for build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216445050&repo=autoland&lineNumber=3703

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=985505cc1347efa4cc451255e976f02d561efe7c

Backout:
https://hg.mozilla.org/integration/autoland/rev/9d13a46a961ad38b629a5dd98029867069bbbb42

Comment 5

[Alex Gaynor [:Alex_Gaynor]]

:sigh:. Uploaded patch which fixes this -- leaving ni? because it conflicts with another patch I in c-n, and I'll just update this and c-n this after that lands.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ffc527a6946
convert several fields in the IPDL compiler from integers to bools; r=nika

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4ffc527a6946