Closed
Bug 1512937
Opened 7 years ago
Closed 6 years ago
Duplicate lookup fragments while creating a URL without a path
Categories
(Toolkit :: Safe Browsing, enhancement, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
Details
Attachments
(2 files)
While looking up something like this, "toplevel.page/?resource=third.party.domain", a duplicate path is generated in LookupCache::GetLookupFragments[1].
We should fix this to avoid unnecessary local lookups.
[1] https://searchfox.org/mozilla-central/rev/dc3585e58b427c3a8a7c01712fe54ebe118a3ce2/toolkit/components/url-classifier/Classifier.cpp#417
|
Assignee | |
Updated•7 years ago
|
Priority: P3 → P2
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dlee
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Summary: Duplicate lookup fragments while url path ended with slash → Duplicate lookup fragments while creating a URL without a path
|
|
Assignee | |
Comment 1•6 years ago
|
||
There were compiler errors while I added a gtest testcase.
This patch updates the Test* files to include a common header, remove redundant headers,
and include missing headers.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D49880
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3d9db5ef4e2
P1. Change the #include order in the Safe Browsing gtest. r=gcp
https://hg.mozilla.org/integration/autoland/rev/ae22a3ec0397
P2. Do not generate an extra framgment for URLs without a path. r=gcp
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a3d9db5ef4e2
https://hg.mozilla.org/mozilla-central/rev/ae22a3ec0397
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•