1512984 - Intermittent [first test after startup] | assertion count 1 is more than expected 0 assertions, with " ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr', file nsCOMPtr.h, line 436" in ScriptPreloader::Observe()

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect, P5)

Description

[Daniel Holbert [:dholbert]]

+++ This bug was initially created as a clone of Bug #1455637 +++

I just hit an assertion-failure that looks very similar to bug 1455637, but slightly different [hence, filing a new bug].  This was in a Try run based on top of yesterday's mozilla-central (specifically, based on https://hg.mozilla.org/mozilla-central/rev/53fd96ca5aa4).  The unlanded patches on the Try run were reflow-related and were unlikely to have been the cause this failure, I think.

Log with the failure:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216189439&repo=try&lineNumber=56959

Slightly-cleaned-up assertion & backtrace shown in the log:
===
Assertion failure: query_result == mRawPtr (QueryInterface needed), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h:449
#01: mozilla::ScriptPreloader::Observe(nsISupports*, char const*, char16_t const*) [xpcom/base/nsCOMPtr.h:434]
#02: nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverList.cpp:65]
#03: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [mozglue/misc/TimeStamp.h:452]
===


(Note that here, the assertion failure is in ScriptPreloader::Observe, whereas bug 1455637 was in ScriptPreloader::InitCache.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: gzipped log from comment 0's test failure

Here's the log, for reference/archival purposes, since it'll be purged from Try before very long.

Comment 2

[Daniel Holbert [:dholbert]]

Tentatively ni'ing :kmag to be sure he sees this, though there may not be much we can do at this point (not sure).

Comment 3

[Intermittent Failures Robot]

1 failures in 2485 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1512984&startday=2018-12-10&endday=2018-12-16&tree=all

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Is this issue still valid?

Comment 5

[Daniel Holbert [:dholbert]]

I haven't seen this since filing, so we can close as WFM I think.