Closed Bug 1513065 Opened 7 years ago Closed 6 years ago

Intermittent GECKO(6424) | SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/build/src/obj-firefox/dist/include/PLDHashTable.h:327:32 in Get

Categories

(Core :: Storage: localStorage & sessionStorage, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: janv)

References

(Blocks 1 open bug)

Details

(Keywords: crash, intermittent-failure, Whiteboard: [stockwell unknown])

Filed by: nbeleuzu [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=216242618&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/fVVZixT2TnOPnAqrNmOJXQ/runs/0/artifacts/public/logs/live_backing.log [task 2018-12-10T20:13:53.676Z] 20:13:53 INFO - TEST-START | dom/base/test/test_blockParsing.html [task 2018-12-10T20:13:54.914Z] 20:13:54 INFO - GECKO(6424) | AddressSanitizer:DEADLYSIGNAL [task 2018-12-10T20:13:54.915Z] 20:13:54 INFO - GECKO(6424) | ================================================================= [task 2018-12-10T20:13:54.916Z] 20:13:54 ERROR - GECKO(6424) | ==6424==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000000a8 (pc 0x7feb11746caa bp 0x7fff023d3e10 sp 0x7fff023d3c60 T0) [task 2018-12-10T20:13:54.917Z] 20:13:54 INFO - GECKO(6424) | ==6424==The signal is caused by a READ memory access. [task 2018-12-10T20:13:54.918Z] 20:13:54 INFO - GECKO(6424) | ==6424==Hint: address points to the zero page. [task 2018-12-10T20:13:55.574Z] 20:13:55 INFO - GECKO(6424) | #0 0x7feb11746ca9 in Get /builds/worker/workspace/build/src/obj-firefox/dist/include/PLDHashTable.h:327:32 [task 2018-12-10T20:13:55.575Z] 20:13:55 INFO - GECKO(6424) | #1 0x7feb11746ca9 in PLDHashTable::Add(void const*, std::nothrow_t const&) /builds/worker/workspace/build/src/xpcom/ds/PLDHashTable.cpp:514 [task 2018-12-10T20:13:55.576Z] 20:13:55 INFO - GECKO(6424) | #2 0x7feb117478fe in PLDHashTable::Add(void const*) /builds/worker/workspace/build/src/xpcom/ds/PLDHashTable.cpp:572:28 [task 2018-12-10T20:13:55.598Z] 20:13:55 INFO - GECKO(6424) | #3 0x7feb190b25d9 in mozilla::dom::WindowGlobalParent::Init(mozilla::dom::WindowGlobalInit const&) /builds/worker/workspace/build/src/dom/ipc/WindowGlobalParent.cpp:68:21 [task 2018-12-10T20:13:55.615Z] 20:13:55 INFO - GECKO(6424) | #4 0x7feb1280c5b6 in RecvPWindowGlobalConstructor /builds/worker/workspace/build/src/ipc/glue/InProcessParent.cpp:21:45 [task 2018-12-10T20:13:55.616Z] 20:13:55 INFO - GECKO(6424) | #5 0x7feb1280c5b6 in non-virtual thunk to mozilla::ipc::InProcessParent::RecvPWindowGlobalConstructor(mozilla::dom::PWindowGlobalParent*, mozilla::dom::WindowGlobalInit const&) /builds/worker/workspace/build/src/ipc/glue/InProcessParent.cpp [task 2018-12-10T20:13:55.622Z] 20:13:55 INFO - GECKO(6424) | #6 0x7feb12c0dc6d in mozilla::ipc::PInProcessParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/PInProcessParent.cpp:157:20 [task 2018-12-10T20:13:55.623Z] 20:13:55 INFO - GECKO(6424) | #7 0x7feb12823069 in mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2159:21 [task 2018-12-10T20:13:55.624Z] 20:13:55 INFO - GECKO(6424) | #8 0x7feb1281fe7c in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2086:9 [task 2018-12-10T20:13:55.625Z] 20:13:55 INFO - GECKO(6424) | #9 0x7feb1282176c in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:1935:3 [task 2018-12-10T20:13:55.626Z] 20:13:55 INFO - GECKO(6424) | #10 0x7feb12821dd7 in mozilla::ipc::MessageChannel::MessageTask::Run() /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:1966:13 [task 2018-12-10T20:13:55.643Z] 20:13:55 INFO - GECKO(6424) | #11 0x7feb11888913 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1157:14 [task 2018-12-10T20:13:55.645Z] 20:13:55 INFO - GECKO(6424) | #12 0x7feb1188fa98 in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:468:10 [task 2018-12-10T20:13:55.647Z] 20:13:55 INFO - GECKO(6424) | #13 0x7feb1282a3fa in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/workspace/build/src/ipc/glue/MessagePump.cpp:88:21 [task 2018-12-10T20:13:55.648Z] 20:13:55 INFO - GECKO(6424) | #14 0x7feb12776fcf in RunInternal /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:314:10 [task 2018-12-10T20:13:55.649Z] 20:13:55 INFO - GECKO(6424) | #15 0x7feb12776fcf in RunHandler /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:307 [task 2018-12-10T20:13:55.650Z] 20:13:55 INFO - GECKO(6424) | #16 0x7feb12776fcf in MessageLoop::Run() /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:289 [task 2018-12-10T20:13:55.651Z] 20:13:55 INFO - GECKO(6424) | #17 0x7feb198eb749 in nsBaseAppShell::Run() /builds/worker/workspace/build/src/widget/nsBaseAppShell.cpp:137:27 [task 2018-12-10T20:13:55.652Z] 20:13:55 INFO - GECKO(6424) | #18 0x7feb1d86a0c0 in nsAppStartup::Run() /builds/worker/workspace/build/src/toolkit/components/startup/nsAppStartup.cpp:271:30 [task 2018-12-10T20:13:55.655Z] 20:13:55 INFO - GECKO(6424) | #19 0x7feb1dab6bd9 in XREMain::XRE_mainRun() /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:4622:22 [task 2018-12-10T20:13:55.657Z] 20:13:55 INFO - GECKO(6424) | #20 0x7feb1dab8f64 in XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:4760:8 [task 2018-12-10T20:13:55.658Z] 20:13:55 INFO - GECKO(6424) | #21 0x7feb1dabaaf0 in XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:4845:21 [task 2018-12-10T20:13:55.666Z] 20:13:55 INFO - GECKO(6424) | #22 0x56535e9631dc in do_main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:214:22 [task 2018-12-10T20:13:55.667Z] 20:13:55 INFO - GECKO(6424) | #23 0x56535e9631dc in main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:293 [task 2018-12-10T20:13:56.114Z] 20:13:56 INFO - GECKO(6424) | #24 0x7feb31a4282f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291 [task 2018-12-10T20:13:56.114Z] 20:13:56 INFO - GECKO(6424) | #25 0x56535e888a98 in _start (/builds/worker/workspace/build/application/firefox/firefox+0x29a98) [task 2018-12-10T20:13:56.114Z] 20:13:56 INFO - GECKO(6424) | AddressSanitizer can not provide additional info. [task 2018-12-10T20:13:56.114Z] 20:13:56 INFO - GECKO(6424) | SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/build/src/obj-firefox/dist/include/PLDHashTable.h:327:32 in Get [task 2018-12-10T20:13:56.114Z] 20:13:56 INFO - GECKO(6424) | ==6424==ABORTING [task 2018-12-10T20:13:56.318Z] 20:13:56 INFO - TEST-INFO | Main app process: exit 0 [task 2018-12-10T20:13:56.322Z] 20:13:56 INFO - runtests.py | Application ran for: 0:00:24.231264 [task 2018-12-10T20:13:56.323Z] 20:13:56 INFO - zombiecheck | Reading PID log: /tmp/tmpMi4ivrpidlog [task 2018-12-10T20:13:56.324Z] 20:13:56 INFO - ==> process 6424 launched child process 6445 [task 2018-12-10T20:13:56.325Z] 20:13:56 INFO - zombiecheck | Checking for orphan process with PID: 6445 [task 2018-12-10T20:13:56.326Z] 20:13:56 INFO - Stopping web server [task 2018-12-10T20:13:56.347Z] 20:13:56 INFO - Stopping web socket server [task 2018-12-10T20:13:56.364Z] 20:13:56 INFO - Stopping ssltunnel [task 2018-12-10T20:13:56.384Z] 20:13:56 WARNING - leakcheck | refcount logging is off, so leaks can't be detected! [task 2018-12-10T20:13:56.386Z] 20:13:56 INFO - runtests.py | Running tests: end. [task 2018-12-10T20:13:56.446Z] 20:13:56 INFO - Buffered messages logged at 20:13:53 [task 2018-12-10T20:13:56.448Z] 20:13:56 INFO - AddTask.js | Entering test [task 2018-12-10T20:13:56.449Z] 20:13:56 INFO - TEST-PASS | dom/base/test/test_blockParsing.html | Should have initial HTML during document-element-inserted
Nika, it looks like `mBrowsingContext` [1] ends up being null. We assert it's non-null in debug builds but not in release. [1] https://searchfox.org/mozilla-central/rev/fd62b95c187a40b328d9e7fd9d848833a6942b57/dom/ipc/WindowGlobalParent.cpp#61
Blocks: 1500944
Component: XPCOM → DOM
Flags: needinfo?(nika)
Component: DOM → DOM: Core & HTML

Moving these bugs (intermittent test failures with crashes) out of P5.

Priority: P5 → --

There are 42 total failures in the last 7 days on linux64 asan: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-04-24&endday=2019-05-01&tree=trunk&bug=1513065

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=243920373&repo=autoland&lineNumber=1683

[task 2019-05-01T14:03:29.964Z] 14:03:29 INFO - TEST-START | browser/base/content/test/captivePortal/browser_CaptivePortalWatcher.js
[task 2019-05-01T14:03:55.398Z] 14:03:55 INFO - GECKO(1081) | AddressSanitizer:DEADLYSIGNAL
[task 2019-05-01T14:03:55.399Z] 14:03:55 INFO - GECKO(1081) | =================================================================
[task 2019-05-01T14:03:55.399Z] 14:03:55 ERROR - GECKO(1081) | ==1161==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000078 (pc 0x7fc7ac55c075 bp 0x7fff4e385690 sp 0x7fff4e385560 T0)
[task 2019-05-01T14:03:55.399Z] 14:03:55 INFO - GECKO(1081) | ==1161==The signal is caused by a READ memory access.
[task 2019-05-01T14:03:55.399Z] 14:03:55 INFO - GECKO(1081) | ==1161==Hint: address points to the zero page.
[task 2019-05-01T14:03:56.604Z] 14:03:56 INFO - GECKO(1081) | #0 0x7fc7ac55c074 in Get /builds/worker/workspace/build/src/obj-firefox/dist/include/PLDHashTable.h:327:32
[task 2019-05-01T14:03:56.604Z] 14:03:56 INFO - GECKO(1081) | #1 0x7fc7ac55c074 in PLDHashTable::Search(void const*) const /builds/worker/workspace/build/src/xpcom/ds/PLDHashTable.cpp:506
[task 2019-05-01T14:03:56.661Z] 14:03:56 INFO - GECKO(1081) | #2 0x7fc7b7bfe217 in GetEntry /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTHashtable.h:135:16
[task 2019-05-01T14:03:56.663Z] 14:03:56 INFO - GECKO(1081) | #3 0x7fc7b7bfe217 in EnsureRemoved /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTHashtable.h:202
[task 2019-05-01T14:03:56.664Z] 14:03:56 INFO - GECKO(1081) | #4 0x7fc7b7bfe217 in EvictCachedContext /builds/worker/workspace/build/src/docshell/base/BrowsingContextGroup.cpp:91
[task 2019-05-01T14:03:56.666Z] 14:03:56 INFO - GECKO(1081) | #5 0x7fc7b7bfe217 in mozilla::dom::BrowsingContext::Detach(bool) /builds/worker/workspace/build/src/docshell/base/BrowsingContext.cpp:282
[task 2019-05-01T14:03:56.667Z] 14:03:56 INFO - GECKO(1081) | #6 0x7fc7b7c2715d in nsDocShell::Destroy() /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:5033:21
[task 2019-05-01T14:03:56.673Z] 14:03:56 INFO - GECKO(1081) | #7 0x7fc7b823974d in nsWebBrowser::SetDocShell(nsIDocShell*) /builds/worker/workspace/build/src/toolkit/components/browser/nsWebBrowser.cpp:1238:23
[task 2019-05-01T14:03:56.677Z] 14:03:56 INFO - GECKO(1081) | #8 0x7fc7b8237bec in nsWebBrowser::InternalDestroy() /builds/worker/workspace/build/src/toolkit/components/browser/nsWebBrowser.cpp:192:3
[task 2019-05-01T14:03:56.678Z] 14:03:56 INFO - GECKO(1081) | #9 0x7fc7b824228c in Destroy /builds/worker/workspace/build/src/toolkit/components/browser/nsWebBrowser.cpp:909:3
[task 2019-05-01T14:03:56.678Z] 14:03:56 INFO - GECKO(1081) | #10 0x7fc7b824228c in non-virtual thunk to nsWebBrowser::Destroy() /builds/worker/workspace/build/src/toolkit/components/browser/nsWebBrowser.cpp
[task 2019-05-01T14:03:56.738Z] 14:03:56 INFO - GECKO(1081) | #11 0x7fc7b4253e94 in mozilla::dom::BrowserChild::DestroyWindow() /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp:981:31
[task 2019-05-01T14:03:56.743Z] 14:03:56 INFO - GECKO(1081) | #12 0x7fc7b426b867 in mozilla::dom::BrowserChild::RecvDestroy() /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp:2359:3
[task 2019-05-01T14:03:56.804Z] 14:03:56 INFO - GECKO(1081) | #13 0x7fc7adff2486 in mozilla::dom::PBrowserChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/PBrowserChild.cpp:5227:20
[task 2019-05-01T14:03:56.913Z] 14:03:56 INFO - GECKO(1081) | #14 0x7fc7ad8d3bb1 in mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/PContentChild.cpp:6482:28
[task 2019-05-01T14:03:56.933Z] 14:03:56 INFO - GECKO(1081) | #15 0x7fc7ad71a3b9 in mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2151:21
[task 2019-05-01T14:03:56.934Z] 14:03:56 INFO - GECKO(1081) | #16 0x7fc7ad717454 in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2078:9
[task 2019-05-01T14:03:56.935Z] 14:03:56 INFO - GECKO(1081) | #17 0x7fc7ad718e5b in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:1937:3
[task 2019-05-01T14:03:56.936Z] 14:03:56 INFO - GECKO(1081) | #18 0x7fc7ad7193c7 in mozilla::ipc::MessageChannel::MessageTask::Run() /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:1968:13
[task 2019-05-01T14:03:56.952Z] 14:03:56 INFO - GECKO(1081) | #19 0x7fc7ac697ac1 in mozilla::SchedulerGroup::Runnable::Run() /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:295:32
[task 2019-05-01T14:03:56.968Z] 14:03:56 INFO - GECKO(1081) | #20 0x7fc7ac6c8b91 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1180:14
[task 2019-05-01T14:03:56.970Z] 14:03:56 INFO - GECKO(1081) | #21 0x7fc7ac6ceca8 in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:486:10
[task 2019-05-01T14:03:56.970Z] 14:03:56 INFO - GECKO(1081) | #22 0x7fc7ad72172f in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/workspace/build/src/ipc/glue/MessagePump.cpp:110:5
[task 2019-05-01T14:03:56.986Z] 14:03:56 INFO - GECKO(1081) | #23 0x7fc7ad64f1e2 in RunInternal /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:315:10
[task 2019-05-01T14:03:56.987Z] 14:03:56 INFO - GECKO(1081) | #24 0x7fc7ad64f1e2 in RunHandler /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:308
[task 2019-05-01T14:03:56.989Z] 14:03:56 INFO - GECKO(1081) | #25 0x7fc7ad64f1e2 in MessageLoop::Run() /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:290
[task 2019-05-01T14:03:56.995Z] 14:03:56 INFO - GECKO(1081) | #26 0x7fc7b4bac559 in nsBaseAppShell::Run() /builds/worker/workspace/build/src/widget/nsBaseAppShell.cpp:137:27
[task 2019-05-01T14:03:56.997Z] 14:03:56 INFO - GECKO(1081) | #27 0x7fc7b880fc1f in XRE_RunAppShell() /builds/worker/workspace/build/src/toolkit/xre/nsEmbedFunctions.cpp:919:20
[task 2019-05-01T14:03:56.998Z] 14:03:56 INFO - GECKO(1081) | #28 0x7fc7ad64f1e2 in RunInternal /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:315:10
[task 2019-05-01T14:03:56.999Z] 14:03:56 INFO - GECKO(1081) | #29 0x7fc7ad64f1e2 in RunHandler /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:308
[task 2019-05-01T14:03:57.000Z] 14:03:57 INFO - GECKO(1081) | #30 0x7fc7ad64f1e2 in MessageLoop::Run() /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:290
[task 2019-05-01T14:03:57.001Z] 14:03:57 INFO - GECKO(1081) | #31 0x7fc7b880f5c6 in XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/workspace/build/src/toolkit/xre/nsEmbedFunctions.cpp:757:34
[task 2019-05-01T14:03:57.018Z] 14:03:57 INFO - GECKO(1081) | #32 0x55754e77a3a7 in content_process_main /builds/worker/workspace/build/src/browser/app/../../ipc/contentproc/plugin-container.cpp:56:28
[task 2019-05-01T14:03:57.018Z] 14:03:57 INFO - GECKO(1081) | #33 0x55754e77a3a7 in main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:263
[task 2019-05-01T14:03:57.096Z] 14:03:57 INFO - GECKO(1081) | #34 0x7fc7ccdfb82f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291
[task 2019-05-01T14:03:57.097Z] 14:03:57 INFO - GECKO(1081) | #35 0x55754e69baf8 in _start (/builds/worker/workspace/build/application/firefox/firefox+0x2aaf8)
[task 2019-05-01T14:03:57.097Z] 14:03:57 INFO - GECKO(1081) | AddressSanitizer can not provide additional info.
[task 2019-05-01T14:03:57.097Z] 14:03:57 INFO - GECKO(1081) | SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/build/src/obj-firefox/dist/include/PLDHashTable.h:327:32 in Get
[task 2019-05-01T14:03:57.098Z] 14:03:57 INFO - GECKO(1081) | ==1161==ABORTING
[task 2019-05-01T14:03:57.563Z] 14:03:57 INFO - GECKO(1081) | ###!!! [Parent][MessageChannel] Error: (msgtype=0x1E008C,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv
[task 2019-05-01T14:03:58.526Z] 14:03:58 INFO - GECKO(1081) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-05-01T14:03:58.527Z] 14:03:58 INFO - GECKO(1081) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2019-05-01T14:03:58.529Z] 14:03:58 INFO - GECKO(1081) | MEMORY STAT | vsize 20975105MB | residentFast 1187MB

Flags: needinfo?(nika)

:hsinyi, could you please assign this to someone?

Flags: needinfo?(htsai)

Hi Andreas,
When looking at comment 17, I see "BrowsingContextGroup.cpp" in the stacktrace and there are changes made to the code recently. Could that be the issue causing failure increase recently? Thank you.

Flags: needinfo?(htsai) → needinfo?(afarre)

Looking at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6b7392710c3e88de7833f098c0886fda54be497&group_state=expanded it looks like the patch that I intend to fix bug 1547871 with also fixes this issue.

Flags: needinfo?(afarre)
Assignee: nobody → afarre
Priority: -- → P2

After the fix for Bug 1547871 landed no reports seem to be because BrowsingContext related issues. All failures in Comment 24 comes through mozilla::dom::LSDatabase::Observer::Observe. Andrew, that's Web Storage, right?

Assignee: afarre → nobody
Component: DOM: Core & HTML → DOM: Web Storage
Flags: needinfo?(bugmail)

Yes, LS is LocalStorage which falls under the Web Storage bucket, thanks for moving this.

Jan, it looks like gLSDatabases is null at https://searchfox.org/mozilla-central/rev/cc280c4be94ff8cf64a27cc9b3d6831ffa49fa45/dom/localstorage/LSDatabase.cpp#373 in the crashes like https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246034918&repo=autoland&lineNumber=5043

This looks like it is probably an instance of a sequence where:

The code was assuming that atomically removing the observer would prevent situations like this, but we ran into nuance that the observer list is snapshotted. Options seem to be:

  • Make the LSDatabase::Observer responsible for adding and removing itself from the observer service. When it removes itself, it sets an internal flag like mRemoved that we use to bail out of the ::Observe notification early.
  • Just check gLSDatabases before using it. Add some comments.
Assignee: nobody → jvarga
Flags: needinfo?(bugmail) → needinfo?(jvarga)

The issue described in comment 26 is being fixed in bug 1548847.

Flags: needinfo?(jvarga)

Yeah, bug 1548847 has been fixed and the orange factor (graph) here also looks good.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Depends on: 1548847
You need to log in before you can comment on or make changes to this bug.