1513076 - Do Not Track string no longer makes sense in Firefox 65

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Tanvi Vyas[:tanvi]]

In the section for Do Not Track in about:preferences#privacy, it says:
Send websites a “Do Not Track” signal that you don’t want to be tracked.
* Always
* Only when Nightly is set to block Detected Trackers

The second option no longer makes sense, because we don't use the terminology "Detected Trackers" anymore.  We need to change this string.

Betsy has proposed:
Only when Nightly is set to block known trackers

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1513076 - Do Not Track string change for Firefox 65.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/663a91125ddf
Do Not Track string change for Firefox 65. r=flod

Comment 3

[Erica Wright [:ewright]]

Comment on attachment 9030330 [details]
Bug 1513076 - Do Not Track string change for Firefox 65.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1473978

User impact if declined: This is a simple string change, if declined we will have misleading terminology in about:preferences.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): the only risk is that this is a string change, so may not be fully translated in time.

String changes made/needed: yes, 1 change

Comment 4

[Erica Wright [:ewright]]

EDIT:

> Is this code covered by automated tests?: no
> Needs manual test from QE?: no

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Erica Wright [:ewright] from comment #3)
> String changes made/needed: yes, 1 change

I'm fine with uplifting this.

Comment 6

[Betsy Mikel [:betsymi]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> (In reply to Erica Wright [:ewright] from comment #3)
> > String changes made/needed: yes, 1 change
> 
> I'm fine with uplifting this.

Thank you Flod.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030330 [details]
Bug 1513076 - Do Not Track string change for Firefox 65.

[Triage Comment]
Fixes a misleading string in Firefox 65. Has Flod's blessing for the string change. Approved for 65.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/318239ee898f

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/663a91125ddf

Comment 10

[Ciprian Georgiu, Desktop QA]

I was able to reproduce this bug using an affected Nightly build from 2018-12-10.

This is verified as fixed on latest Nightly 66.0a1 (2018-12-11) and Beta 65.0b4 (20181211223337) on the following OSes: Win 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64. I can confirm that the second option is now called "Only when Firefox/Nightly is set to block known trackers" in about:preferences#privacy.