1513175 - [socket-proc] PBackground yells it wants to live on the parent process only

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Honza Bambas (:mayhemer)]

I got this assertion failure during shutdown on the socket process:

 	xul.dll!`anonymous namespace'::AssertIsInMainProcess() Line 79	C++
	xul.dll!`anonymous namespace'::ParentImpl::TimerCallbackClosure::TimerCallbackClosure(0x000002011683fc00, 0x00000201168635d0) Line 128	C++
 	xul.dll!`anonymous namespace'::ParentImpl::ShutdownBackgroundThread() Line 1091	C++
 	xul.dll!`anonymous namespace'::ParentImpl::ShutdownObserver::Observe(0x0000000000000000, 0x00007ffd52f1b910, 0x0000000000000000) Line 1219	C++
 	xul.dll!nsObserverList::NotifyObservers(0x0000000000000000, 0x00007ffd52f1b910, 0x0000000000000000) Line 79	C++
 	xul.dll!nsObserverService::NotifyObservers(0x0000000000000000, 0x00007ffd52f1b910, 0x0000000000000000) Line 318	C++
 	xul.dll!mozilla::ShutdownXPCOM(0x0000000000000000) Line 910	C++
 	xul.dll!NS_ShutdownXPCOM(0x0000000000000000) Line 821	C++
 	xul.dll!mozilla::net::SocketProcessChild::CleanUp() Line 135	C++
 	xul.dll!mozilla::net::SocketProcessImpl::CleanUp() Line 179	C++
 	xul.dll!XRE_InitChildProcess(15, 0x0000020114304020, 0x000000bc857ff6e0) Line 798	C++
 	xul.dll!mozilla::BootstrapImpl::XRE_InitChildProcess(17, 0x0000020114304020, 0x000000bc857ff6e0) Line 69	C++
 	firefox.exe!content_process_main(0x0000020114309100, 17, 0x0000020114304020) Line 50	C++
 	firefox.exe!NS_internal_main(18, 0x0000020114304020, 0x0000020113e27990) Line 287	C++
 	firefox.exe!wmain(18, 0x0000020113e2bd60) Line 143	C++
 	firefox.exe!__scrt_common_main_seh() Line 288	C++
 	kernel32.dll!BaseThreadInitThunk()	Unknown
 	ntdll.dll!RtlUserThreadStart()	Unknown

It may be just about changing the assertion to AssertIsInMainOrSocketProcess()?

Comment 1

[Kershaw Chang [:kershaw]]

(In reply to Honza Bambas (:mayhemer) from comment #0)
> I got this assertion failure during shutdown on the socket process:
> 
>  	xul.dll!`anonymous namespace'::AssertIsInMainProcess() Line 79	C++
> 	xul.dll!`anonymous
> namespace'::ParentImpl::TimerCallbackClosure::
> TimerCallbackClosure(0x000002011683fc00, 0x00000201168635d0) Line 128	C++
>  	xul.dll!`anonymous namespace'::ParentImpl::ShutdownBackgroundThread() Line
> 1091	C++
>  	xul.dll!`anonymous
> namespace'::ParentImpl::ShutdownObserver::Observe(0x0000000000000000,
> 0x00007ffd52f1b910, 0x0000000000000000) Line 1219	C++
>  	xul.dll!nsObserverList::NotifyObservers(0x0000000000000000,
> 0x00007ffd52f1b910, 0x0000000000000000) Line 79	C++
>  	xul.dll!nsObserverService::NotifyObservers(0x0000000000000000,
> 0x00007ffd52f1b910, 0x0000000000000000) Line 318	C++
>  	xul.dll!mozilla::ShutdownXPCOM(0x0000000000000000) Line 910	C++
>  	xul.dll!NS_ShutdownXPCOM(0x0000000000000000) Line 821	C++
>  	xul.dll!mozilla::net::SocketProcessChild::CleanUp() Line 135	C++
>  	xul.dll!mozilla::net::SocketProcessImpl::CleanUp() Line 179	C++
>  	xul.dll!XRE_InitChildProcess(15, 0x0000020114304020, 0x000000bc857ff6e0)
> Line 798	C++
>  	xul.dll!mozilla::BootstrapImpl::XRE_InitChildProcess(17,
> 0x0000020114304020, 0x000000bc857ff6e0) Line 69	C++
>  	firefox.exe!content_process_main(0x0000020114309100, 17,
> 0x0000020114304020) Line 50	C++
>  	firefox.exe!NS_internal_main(18, 0x0000020114304020, 0x0000020113e27990)
> Line 287	C++
>  	firefox.exe!wmain(18, 0x0000020113e2bd60) Line 143	C++
>  	firefox.exe!__scrt_common_main_seh() Line 288	C++
>  	kernel32.dll!BaseThreadInitThunk()	Unknown
>  	ntdll.dll!RtlUserThreadStart()	Unknown
> 
> It may be just about changing the assertion to
> AssertIsInMainOrSocketProcess()?

Yes! I've changed the assertion in ShutdownBackgroundThread(), but I missed the assertion in TimerCallbackClosure.
Thanks for finding this issue.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1513175 - Change the assetion to AssertIsInMainOrSocketProcess

Comment 3

[Kershaw Chang [:kershaw]]

This is fixed and landed.