Closed
Bug 1513245
Opened 5 years ago
Closed 5 years ago
Warning: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Categories
(GeckoView :: General, defect)
GeckoView
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: fluffyemily, Assigned: fluffyemily)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
org.mozilla.geckoview.GeckoSession.LoadFlags: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.ProgressDelegate.SecurityInformation.SecurityMode: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.ProgressDelegate.SecurityInformation.ContentType: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.ContentDelegate.ContextElement.Type: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.SelectionActionDelegate.Flag: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.SelectionActionDelegate.Action: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.SelectionActionDelegate.HideReason: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.NavigationDelegate.TargetWindow: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PromptDelegate.AuthOptions.AuthFlag: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PromptDelegate.AuthOptions.AuthLevel: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PromptDelegate.Choice.ChoiceType: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PromptDelegate.DatetimeType: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PromptDelegate.FileType: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PermissionDelegate.Permission: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PermissionDelegate.MediaSource.Source: The typedef annotation should have @Retention(RetentionPolicy.SOURCE) org.mozilla.geckoview.GeckoSession.PermissionDelegate.MediaSource.Type: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
|
||
Comment 1•5 years ago
|
||
It would be nice if we could also hide them from the API, right now we hide some of them but not all.
|
Assignee | |
Comment 2•5 years ago
|
||
(In reply to Agi [:agi] from comment #1) > right now we hide some of them but not all. How do we do this currently? Is it simply updating the access modifier?
|
|
Assignee | |
Comment 3•5 years ago
|
||
These annotations do no need to be kept by the compiler and can be discarded.
Pushed by etoop@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c49f01ef8a8f Add `RetentionPolicy.SOURCE` to type def annotations r=geckoview-reviewers,agi,esawin
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c49f01ef8a8f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•5 years ago
|
Keywords: good-first-bug
Target Milestone: Firefox 66 → mozilla66
|
|
||
Updated•5 years ago
|
Keywords: good-first-bug
You need to log in
before you can comment on or make changes to this bug.
Description
•