1513346 - cleanup after python 3 migration

Status: RESOLVED FIXED

(Socorro :: General, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

six is a really great library for easing the complexity of migrating from Python 2 to Python 3. Now that we've completed the migration, it behooves us to cleanup the code and remove six-isms.

This bug covers that.

Probably makes sense to do it directory by directory.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4836: bug 1513346: import Queue from non-six place

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #4836: "bug 1513346: import Queue from non-six place" in 9ec3689.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm adjusting the scope here to all Python 3 migration cleanup.

1. remove usage of six library
2. switch from mock to unittest.mock
3. anything else we discover before closing this bug out

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4880: bug 1513346: remove python 2 bits from signature generation

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #4880: "bug 1513346: remove python 2 bits from signature generation" in 4871a4e.

Comment 6

[John Whitlock [:jwhitlock]]

Attachment: pr 4928: bug 1513346: Convert six to native Python 3

Convert most six usage to native Python 3, with the exception of six.reraise.

Comment 7

[John Whitlock [:jwhitlock]]

jwhitlock merged PR #4928: "bug 1513346: Convert six to native Python 3" in 726d9e9.

Comment 8

[John Whitlock [:jwhitlock]]

jwhitlock merged PR #4935: "bug 1513346: Migrate six.reraise to standard raise" in 750dece.

Deployed to stage, and tested with reprocessing https://crash-stats.allizom.org/report/index/594c512e-561d-4d05-92b0-992b20190519. It continues to have the ElasticSearch indexing error (bug 1503344). It results in 2 Sentry events. The first is a KeyError traceback, and the second is the wrapping PolyStorageError. The logs include a traceback, as well as the "error in processing or saving crash 594c512e-561d-4d05-92b0-992b20190519" message.

Comment 9

[John Whitlock [:jwhitlock]]

Deployed to production, six library is no longer used by Socorro code (although it is used by installed packages). Remaining issues that I know about.

1. Switch from mock to unittest.mock
2. Switch from class Foo(object): to class Foo:

willkg and I also discussed removing some empty __init__.py files, to use the implicit namespaced packages added in Python 3.3 (see PEP 420). Some could be removed, such as webapp-django/crashstats/*/management/__init__.py, but removing all of them starts breaking tests. We'll stick with the Python 2 convention of always including it for now.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

This bug was specifically about removing six-isms which were there to help us migrate from Python 2 to Python 3. Now that six use is gone, we're good, so I'm going to mark this FIXED.