1513366 - Add C++ helper for importing a JS module and wrapping in an XPIDL interface.

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Kris Maglione [:kmag]]

This should allow us to simply define XPIDL interfaces for the symbols exported from a JSM and then import those modules directly, rather than go through all of the mess and overhead of registering them as components.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1513366: Part 1 - Add do_ImportModule helper for importing JS modules. r=mccr8

This helper makes it considerably easier for C++ code to import a JS module
and wrap it in an appropriately-defined XPIDL interface for its exports.
Typical usage is something like:

Foo.jsm:

  var EXPORTED_SYMBOLS = ["foo"];

  function foo(bar) {
    return bar.toString();
  }

mozIFoo.idl:

  interface mozIFoo : nsISupports {
    AString foo(double meh);
  }

Thing.cpp:

  nsCOMPtr<mozIFoo> foo = do_ImportModule(
    "resource://meh/Foo.jsm");

  MOZ_TRY(foo->Foo(42));

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1513366: Part 2 - Update MemoryTelemetry to use do_ImportModule. r=erahm

It makes things much simpler.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1513366: Part 3 - Update txEXSLTFunctions to use do_ImportModule. r=Ehsan

This makes the code much simpler, and also likely much more efficient, since
it does not involve creating a sandbox, and the resulting copies and
cross-compartment-wrapper overhead.

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1513366: Part 4 - Use do_ImportModule in WebReplay code. r=bhackett

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1513366: Part 5 - Migrate extension process script to a JSM. r=aswan

This simplifies things all around, and gets rid of one more unnecessary
component registration.

Comment 6

[Kris Maglione [:kmag]]

Attachment: Part 2 - Update MemoryTelemetry to use do_ImportModule

It makes things much simpler.

Differential Revision: https://phabricator.services.mozilla.com/D14210

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e6ff65ae3305d337684d9e7d44a83aa594b132e
Bug 1513366: Part 1 - Add do_ImportModule helper for importing JS modules. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a96de7a04728e56eb0b89fabb5ab769d3de97de
Bug 1513366: Part 2 - Update MemoryTelemetry to use do_ImportModule. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/8aa82890a1ab7ca428f300fbc38d461939763548
Bug 1513366: Part 3 - Update txEXSLTFunctions to use do_ImportModule. r=Ehsan

https://hg.mozilla.org/integration/mozilla-inbound/rev/945badc82d9ab5f41c81b074d9442f84f1c0c2b3
Bug 1513366: Part 4 - Use do_ImportModule in WebReplay code. r=bhackett

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dce47a0184b26b38ba08a387ac6a931f6a81012
Bug 1513366: Part 5 - Migrate extension process script to a JSM. r=aswan

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5e6ff65ae330
https://hg.mozilla.org/mozilla-central/rev/8a96de7a0472
https://hg.mozilla.org/mozilla-central/rev/8aa82890a1ab
https://hg.mozilla.org/mozilla-central/rev/945badc82d9a
https://hg.mozilla.org/mozilla-central/rev/3dce47a0184b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/03ca21bafc5f
Port bug 1513366 - remove extension-process-script.js from package manifest. rs=bustage-fix DONTBUILD