Closed Bug 1513492 Opened Last year Closed 8 months ago

Instruction name shakeup, December 2018 edition

Categories

(Core :: Javascript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: lth, Assigned: info, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

We should track the recent changes to instruction names by introducing aliases for the new variants until we can run a rename on all code that uses the old variants.

The summary of relevant changes is probably clearest here, note that some of the instruction names are parameterized:

https://github.com/WebAssembly/spec/pull/926/files#diff-ffe7a4ab22e4922ac53520ef68816dd6
Blocks: 1527871
Duplicate of this bug: 1534433
Mentor: lhansen

The text format of the instructions wrap, extend, trunc, convert, demote,
promote, and reinterpret was changed recently to make them more consistent.
Signedness now appears after the type; e.g. trunc_f32_s instead of trunc_s/f32.
Also, local.tee can now be used besides tee_local.

See https://github.com/WebAssembly/wabt/issues/933 for reference.

Thanks! The next step here is to request a review on the patch. Supposing you want me to review this ... you can either add "r?lth" to the end of the subject line of the patch and re-upload the patch and then things should take care of themselves, or in the Phabricator UI for the patch you can select "Edit Revision" and then it should be possible for you to add a reviewer in the field for that.

Flags: needinfo?(info)

I wasn't sure if I was supposed to do that myself or not, but I have added a review request for you now. Thanks in advance!

Flags: needinfo?(info)

leave-open since the atomic operations still need to be done.

Assignee: nobody → info
Keywords: leave-open

Thanks for the review. I have added the atomic operations to https://phabricator.services.mozilla.com/D25540. Also, I do not have privileges to land the patch, so help with that would be much appreciated!

Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0a1f6c8e4d1
Add support for a number of new (2018/12) text versions of WebAssembly instructions r=lth
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.