Closed Bug 1513497 Opened Last year Closed 11 months ago
Trying to upload symbols for Flashplayer with latest dump
_syms, getting error "Unrecognized file pattern ."
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36 Steps to reproduce: I am vivek from Adobe. I am trying to upload symbols for Flashplayer on https://symbols.mozilla.org/uploads I am using the latest dump_syms ( dump_syms_vc1800) tool present at here https://hg.mozilla.org/mozilla-central/file/tip/toolkit/crashreporter/tools/win32.When i am trying to upload the .sym file to mozilla symbols repository, it says : " Unrecognized file pattern. Should only be <module>/<hex>/<file> or <name>-symbols.txt and nothing else." Can you help me in this ? -Vivek Actual results: " Unrecognized file pattern. Should only be <module>/<hex>/<file> or <name>-symbols.txt and nothing else." Expected results: Symbols should be uploaded properly.
Component: Untriaged → Symbols
Product: Firefox → Socorro
Summary: dump_syms → Trying to upload symbols for Flashplayer with latest dump_syms, getting error "Unrecognized file pattern."
Version: 66 Branch → unspecified
Hi, The error isn't really an unexpected error. The .zip file you're trying to upload doesn't have the files inside it in the right way. Here's what you should see when you run `unzip -l` on the file for example: https://gist.github.com/peterbe/e0d81b0a6e53c4c380252fc51c1fee71 So, for example the line `AccessibleMarshal.dll/58DF8E1BC000/AccessibleMarshal.dl_` means there's a "root" folder called "AccessibleMarshal.dll" which containers a folder called "58DF8E1BC000" and that folder contains a file called "AccessibleMarshal.dl_" The code that does this stuff is here: https://github.com/mozilla-services/tecken/blob/3e40fc8c5c7ec77049cefc300b5cfcef5e58f26a/tecken/upload/views.py#L53-L85 One thing I think *I* could do to prevent this from happening again is *include* the line that caused the error. Then the error message would instead be something like: "Unrecognized file pattern. Should only be <module>/<hex>/<file> or <name>-symbols.txt and nothing else. (Not prefix/wrong/010101/suffix.example)" That might help debug it for you. However, more important, **where did you read about how to make a ZIP?** Clearly those instructions didn't help. Or perhaps you simply couldn't find them.
Assignee: nobody → peterbe
Hi Peter, Thanks for the help. This zip file i upload contains the actual file and corresponding .pdb and.sym file. Do I need to upload only .sym file ?
Why don't you email me the .zip file you tried and I'll take a look. I think my email is visible here on Bugzilla, right?
Or, if you can't email the .zip file to me, can you run: `unzip -l` on it and show me what it says?
Hi Peter, I upload files in a ZIP format which includes .dll file and its corresponding .pdb and .sym files. Do all these files need to be uploaded or .sym file is sufficient. I have shared a .sym file for one of the builds at this location: https://adobe.ly/2F9GNbc Please check if it correct. -Vivek
(In reply to Vivek Negi from comment #5) > Hi Peter, > > I upload files in a ZIP format which includes .dll file and its > corresponding .pdb and .sym files. Good. Can you email me (email@example.com) the file you're attempting to upload? > Do all these files need to be uploaded or .sym file is sufficient. All files. 4 months ago you did manage to upload some files. They contained .exe, .pdb, and .sym https://symbols.mozilla.org/uploads/upload/29338 > > I have shared a .sym file for one of the builds at this location: > https://adobe.ly/2F9GNbc > Please check if it correct. I don't know what that is. It appears to be a .sym file displayed as a document or something. Any chance you can email the zip file you're having trouble with to me?
Hi Peter, Just sent you an email. Please have a look. -Vivek
(In reply to Vivek Negi from comment #7) The message was not delivered because attachment was too large. I shared the ZIP file at this location : https://adobe.ly/2F3t1I1 Just download it and have a look. > Hi Peter, > > Just sent you an email. Please have a look. > -Vivek
As you can see from...: ``` ▶ unzip -l NPSWF32_32_0_0_101.zip Archive: NPSWF32_32_0_0_101.zip Length Date Time Name --------- ---------- ----- ---- 97300480 12-10-2018 21:03 NPSWF32.pdb 26919746 01-03-2019 19:29 NPSWF32.sym 19909632 12-10-2018 21:03 NPSWF32_32_0_0_101.dll --------- ------- 144129858 3 files ``` The files are in the root of the zip. Each file is supposed to be a directory. And in each (or, where appropriate) there's supposed to be another directory which is all hex characters and then in there the files are supposed to be. I appreciate that the documentation is sparse about how to make these but here it says: "The final check is that each file path in the zip file matches the pattern <module>/<hex>/<file> or <name>-symbols.txt. All other file paths are rejected." I know you've managed to upload valid .zip files before so you must have seen the module and hex directories (aka. the debugID) before.  https://tecken.readthedocs.io/en/latest/upload.html#checks-and-validations
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.