1513512 - A gfx demo spends most of its time (250ms) in styling

Status: RESOLVED DUPLICATE of bug 1493420

(Core :: CSS Parsing and Computation, defect)

Description

[Mayank Bansal]

Attachment: surane_5000.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

This is the "surane" demo which is used to test WR etc.

IF you change the container.innerHTML to 5000 , the demo spends 300ms in styling
Not sure if this is expected or not. Feel free to WONTFIX this as needed.


Actual results:

lots of time spend in styling.

Array 5000 : https://perfht.ml/2SJUmC2
ray 500 : https://perfht.ml/2SG5EqM


Expected results:

maybe not so

Comment 1

[Mayank Bansal]

Attachment: surane_500.html

the default testcase, which spends more time in gfx as expected

Comment 2

[Mayank Bansal]

Here is the sequential stylo profile of the 5000 case : https://perfht.ml/2SG7mbG

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Looks like the same root cause / fix as bug 1493420.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This should look much better now, mind confirming? The testcase in comment 0 still spends a long time in styling, and I think I could spend some time trying to optimize out various bits here and there.

Please reopen if you still think it's bad and I'll take a look :)

Comment 5

[Mayank Bansal]

Profile with 5000 : http://bit.ly/2WxU4DM . Time reduced from ~300ms to ~90ms in styling.
I dont know if optimising further is worth pursuing or not . For reference, Chrome performs worse than Nightly.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Great. That works for me, for now at least, gotta do other stuff :)